Juju Charms Collection
swift-proxy package

Merge lp://staging/~billy-olsen/charms/trusty/swift-proxy/public-endpoint-host into lp://staging/~openstack-charmers-archive/charms/trusty/swift-proxy/next

  1. Trusty Tahr (14.04)
  2. public-endpoint-host
  3. Merge into next
Proposed by Billy Olsen
Status: Merged
Merged at revision: 98
Proposed branch: lp://staging/~billy-olsen/charms/trusty/swift-proxy/public-endpoint-host
Merge into: lp://staging/~openstack-charmers-archive/charms/trusty/swift-proxy/next
Diff against target: 291 lines (+155/-48)
3 files modified
config.yaml (+12/-0)
hooks/charmhelpers/contrib/openstack/ip.py (+49/-44)
unit_tests/test_swift_hooks.py (+94/-4)
To merge this branch: bzr merge lp://staging/~billy-olsen/charms/trusty/swift-proxy/public-endpoint-host
Reviewer Review Type Date Requested Status
Corey Bryant Approve
Review via email: mp+261005@code.staging.launchpad.net

Description of the change

Provides a config option which allows the user to specify the public hostname used to advertise to keystone when creating endpoints.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #5043 swift-proxy-next for billy-olsen mp261005
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/5043/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #4723 swift-proxy-next for billy-olsen mp261005
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/4723/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #4449 swift-proxy-next for billy-olsen mp261005
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/4449/

lp://staging/~billy-olsen/charms/trusty/swift-proxy/public-endpoint-host updated
99. By Billy Olsen

c-h sync

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #5074 swift-proxy-next for billy-olsen mp261005
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/5074/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #4753 swift-proxy-next for billy-olsen mp261005
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/4753/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #4481 swift-proxy-next for billy-olsen mp261005
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/4481/

Revision history for this message
Corey Bryant (corey.bryant) wrote :

Looks good! Mind adding a unit test?

lp://staging/~billy-olsen/charms/trusty/swift-proxy/public-endpoint-host updated
100. By Billy Olsen

Add unit test for public hostname.

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #5344 swift-proxy-next for billy-olsen mp261005
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/5344/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #4976 swift-proxy-next for billy-olsen mp261005
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/4976/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #4585 swift-proxy-next for billy-olsen mp261005
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/4585/

Revision history for this message
Corey Bryant (corey.bryant) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches