Merge lp://staging/~bilalakhtar/update-manager/unity-quicklist into lp://staging/update-manager

Proposed by Bilal Akhtar
Status: Merged
Merged at revision: 2103
Proposed branch: lp://staging/~bilalakhtar/update-manager/unity-quicklist
Merge into: lp://staging/update-manager
Diff against target: 77 lines (+30/-1)
1 file modified
UpdateManager/UpdateManager.py (+30/-1)
To merge this branch: bzr merge lp://staging/~bilalakhtar/update-manager/unity-quicklist
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Review via email: mp+57289@code.staging.launchpad.net

Description of the change

This branch adds unity dynamic quicklist support for update-manager. Would need a UIFe before the merge.

To post a comment you must log in.
2095. By Bilal Akhtar

Minor changes to make signal callbacks suit both those of Gtk and Dbusmenu

2096. By Bilal Akhtar

Disable/enable the install menu item as per the update status

2097. By Bilal Akhtar

Move dbusmenu and Unity declaration to the top of script

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Hi Michael,

I tested this, and it should work provided that Unity is built from this branch: https://code.launchpad.net/~ken-vandine/unity/make-quicklists-work-again/+merge/57386

Its a bug in Unity, and another bug which makes Unity crash if the dbusmenu contains a hidden item. So we have 2 options:

1) Get this fix in after those bugs are fixed in Unity.
2) Ignore this for Natty, we'll add it in Oneiric (I prefer this for now; taking into consideration the fact that UIF is in place).

What do you think?

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks a bunch I merged this into my "for-unity" branch and will push it out once natty is released. I like it a lot but it arrived a little bit late.

Revision history for this message
Michael Vogt (mvo) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: