unity-lens-applications

Merge lp://staging/~bilalakhtar/unity-lens-applications/fix-750262 into lp://staging/unity-lens-applications

fix-750262
Merge into trunk

Proposed by Bilal Akhtar on 2011-04-06

Status:

Merged

Merged at revision:

201

Proposed branch:

lp://staging/~bilalakhtar/unity-lens-applications/fix-750262

Merge into:

lp://staging/unity-lens-applications

Diff against target:

29 lines (+14/-5)

1 file modified

src/daemon.vala (+14/-5)

To merge this branch:

bzr merge lp://staging/~bilalakhtar/unity-lens-applications/fix-750262

Low

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Mikkel Kamstrup Erlandsen (community)		2011-04-06	Approve on 2011-04-07
Review via email: mp+56526@code.staging.launchpad.net

Description of the change

This branch fixes bug #750262 .

Revision history for this message

Mikkel Kamstrup Erlandsen (kamstrup) wrote on 2011-04-06:

There's something about this implementation I don't like too much. Right now you extract the package name and pass it to software-center. This only works by chance.

The "correct" way would be to pass the full "apt:package_name" string to AppInfo.launch_default_for_uri() because the apt: scheme is already registered with GNOME as you can verify by running "gnome-open apt:xterm" in a terminal.

review: Needs Fixing

Revision history for this message

Mikkel Kamstrup Erlandsen (kamstrup) wrote on 2011-04-06:

(and note - the reason why the unity-install:// scheme doesn't work "by chance" in general is because we extract all the metadata directly from software-center's own index when constructing the URL)

lp://staging/~bilalakhtar/unity-lens-applications/fix-750262 updated on 2011-04-06

202. By Bilal Akhtar on 2011-04-06: Make sure apturl runs in the case of an apt: url, and not software-center

Revision history for this message

Mikkel Kamstrup Erlandsen (kamstrup) wrote on 2011-04-07:

Awesome Bilal! I saw your ping on IRC yesterday just when my laptop's battery died. I still think that AppInfo.launch_default_for_uri() is the right choice. The apt:foo thing is mainly for power users and I am not convinced they appreciate a full S-C launched.

And using the GNOME URI handling we give the platform team the option to install the software-center as apt: URI handler if they see that as better. Which hardcoding S-C doesn't make room for.

Your patch will be included in todays tarball.

review: Approve