Aptdaemon

Merge lp://staging/~bilalakhtar/aptdaemon/unity-integration into lp://staging/aptdaemon

unity-integration
Merge into main

Proposed by Bilal Akhtar on 2011-06-07

Status:

Needs review

Proposed branch:

lp://staging/~bilalakhtar/aptdaemon/unity-integration

Merge into:

lp://staging/aptdaemon

Diff against target:

43 lines (+19/-0)

1 file modified

aptdaemon/gtkwidgets.py (+19/-0)

To merge this branch:

bzr merge lp://staging/~bilalakhtar/aptdaemon/unity-integration

Wishlist

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Michael Vogt (community)		2011-06-07	Needs Fixing on 2011-06-10
Review via email: mp+63673@code.staging.launchpad.net

Description of the change

Check if the client is update-manager. If yes, then throw away progress stats to libunity. To make this work fully, lp:~bilalakhtar/update-manager/unity-launcher-progress should merge into lp:update-manager after this branch is merged into lp:aptdaemon.

This branch merge is a part of the blueprint https://blueprints.launchpad.net/ubuntu/+spec/desktop-o-default-apps-unity-integration .

Merging this code into aptdaemon could facilitate unity integration in other apps using aptdaemon as well, in the future.

Revision history for this message

Michael Vogt (mvo) wrote on 2011-06-10:

Thanks for your branch! I merged this support in a slighly different way into update-manager.

As for a generic solution in aptdaemon I think this needs more generalization and ideally its own aptdaemon.unityprogress that just takes the transaction and a application name. This way its more generic then to include it in the gtkwidgets.

Feedback from Sebastian is also welcome on this.

review: Needs Fixing

Revision history for this message

Bilal Akhtar (bilalakhtar) wrote on 2011-06-11:

Well, the only purpose why I embedded this thing inside aptdaemon was because it was more closely tied to the progress bar. That isn't an efficient way to do this, and hence I guess it might be better to just leave things in aptdaemon as it is. I don't think any other app using aptdaemon would need launcher integration (except software-center, where it'll be implemented very differently).

Revision history for this message

Sebastian Heinlein (glatzor) wrote on 2011-06-11:

There are also other applications using aptdaemon which could make use of the progress bar:

sessioninstaller
language-selector-gnome
oem-config
gnome-codec-install

I am quite short on time. But I will have a look at this at Tuesday.

Revision history for this message

Robert Roth (evfool) wrote on 2011-08-01:

What's the status on this? Does update-manager have unity integration? I have checked the update-manager and aptdaemon source, and neither do have update-manager progress indication support, and the feature-freeze is close.

Sebastian, please provide some more feedback, do you agree with mvo on having a separate aptdaemon.unityprogress to have a general solution?

Just asking to find out what needs to be done to have this ready for oneiric.

Revision history for this message

Michael Vogt (mvo) wrote on 2011-08-01:

On Mon, Aug 01, 2011 at 08:21:15AM -0000, Robert Roth wrote:
> What's the status on this? Does update-manager have unity integration? I have checked the update-manager and aptdaemon source, and neither do have update-manager progress indication support, and the feature-freeze is close.
[..]

update-manager will use unity if its available and show progress
information and number of available updates. But having a more general
progress in aptdaemon would certainly be a good thing.

Cheers,
Michael

Unmerged revisions

661. By Bilal Akhtar on 2011-06-07: If Update-Manager is running, export progress information to libunity. This code may also make it easier for other apps using aptdaemon to integrate with Unity, beginning with update-manager