Merge lp://staging/~bigkevmcd/python-jenkins/fix-bug-1000799-urlquote into lp://staging/~python-jenkins-developers/python-jenkins/trunk

Proposed by Kevin McDermott
Status: Merged
Merged at revision: 15
Proposed branch: lp://staging/~bigkevmcd/python-jenkins/fix-bug-1000799-urlquote
Merge into: lp://staging/~python-jenkins-developers/python-jenkins/trunk
Diff against target: 58 lines (+29/-2)
4 files modified
Makefile (+2/-0)
jenkins/__init__.py (+3/-2)
tests/helper.py (+5/-0)
tests/test_jenkins.py (+19/-0)
To merge this branch: bzr merge lp://staging/~bigkevmcd/python-jenkins/fix-bug-1000799-urlquote
Reviewer Review Type Date Requested Status
James Page Pending
Review via email: mp+106206@code.staging.launchpad.net

Description of the change

I've added some test infrastructure, and am happy to fix the other methods which suffer from the same problem prior to merging, if this approach is of interest.

To post a comment you must log in.
Revision history for this message
Kevin McDermott (bigkevmcd) wrote :

I should add, this requires the "mock" library for Python, which is available on Pypi, and is standard from Python 3.3.

15. By Kevin McDermott

Some extraneous imports.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches