Merge lp://staging/~bialix/bzr-windows-installers/changelog_plugin into lp://staging/bzr-windows-installers

Proposed by Alexander Belchenko
Status: Merged
Approved by: John A Meinel
Approved revision: 172
Merge reported by: Alexander Belchenko
Merged at revision: not available
Proposed branch: lp://staging/~bialix/bzr-windows-installers/changelog_plugin
Merge into: lp://staging/bzr-windows-installers
Diff against target: 56 lines (+9/-1)
1 file modified
bazaar_releases.py (+9/-1)
To merge this branch: bzr merge lp://staging/~bialix/bzr-windows-installers/changelog_plugin
Reviewer Review Type Date Requested Status
John A Meinel Approve
Review via email: mp+66760@code.staging.launchpad.net

Description of the change

Add built-in changelog_merge plugin to standalone installer.

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 7/4/2011 11:19 AM, Alexander Belchenko wrote:
> Alexander Belchenko has proposed merging lp:~bialix/bzr-windows-installers/changelog_plugin into lp:bzr-windows-installers.
>
> Requested reviews:
> Bazaar Developers (bzr)
>
> For more details, see:
> https://code.launchpad.net/~bialix/bzr-windows-installers/changelog_plugin/+merge/66760
>
> Add built-in changelog_merge plugin to standalone installer.

The changelog_merge plugin doesn't exist in the 2.2 or 2.3 releases,
only in 2.4 and trunk. So I edited the code to not try to install it in
the older versions, and merged this.

 merge: approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk4S5IQACgkQJdeBCYSNAAM+cQCeJCYIfslb+pg8HS0X8/4DkTeZ
3KoAoIa6GzFrACswSYFaEFsLpiPJ5nYp
=HyVk
-----END PGP SIGNATURE-----

review: Approve
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 7/4/2011 11:19 AM, Alexander Belchenko wrote:
> Alexander Belchenko has proposed merging lp:~bialix/bzr-windows-installers/changelog_plugin into lp:bzr-windows-installers.
>
> Requested reviews:
> Bazaar Developers (bzr)
>
> For more details, see:
> https://code.launchpad.net/~bialix/bzr-windows-installers/changelog_plugin/+merge/66760
>
> Add built-in changelog_merge plugin to standalone installer.

Also Alexander, you still have all of the 'bzr' tags in your branch. You
can run:

 cd bzr-windows-installers
 for t in `cat deleted_tags.txt`; do bzr tag --delete $t; done

I'm not sure how else for you to do it. (You can copy the
.bzr/branch/tags file from Launchpad and overwrite your own, I guess.)

I noticed because bzr>2.3 will copy all the revisions for all the tags,
which means that committing/pushing to a bzr-windows-installers branch
will copy up the whole history of bzr if you haven't deleted the extra tags.

It is a little bit cumbersome, I agree. The other option is to delete
your local branch, and start from scratch from
'lp:bzr-windows-installers'. I've verified that it doesn't have the
extra tags.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk4S5VAACgkQJdeBCYSNAAOnsQCgzIvS2jo1GX83MktvsIAAFbxz
WO0AniDIkLTGvAnMJ9MGMxwqEq15Pt80
=qZAi
-----END PGP SIGNATURE-----

Revision history for this message
Alexander Belchenko (bialix) wrote :

John Arbash Meinel пишет:
> Also Alexander, you still have all of the 'bzr' tags in your branch.

> It is a little bit cumbersome, I agree. The other option is to delete
> your local branch, and start from scratch from
> 'lp:bzr-windows-installers'. I've verified that it doesn't have the
> extra tags.

Oops. I'll re-create the branch from scratch.

thank you for reviewing it, I didn't realize this change should be
applied only for 2.4 and trunk, not sure why I did such mistake.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches