Merge lp://staging/~bhavesh-goyal093/postorius/postorius-fix-ui into lp://staging/postorius
Proposed by
Bhavesh Goyal
| Status: | Needs review | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://staging/~bhavesh-goyal093/postorius/postorius-fix-ui | ||||
| Merge into: | lp://staging/postorius | ||||
| Diff against target: |
71 lines (+30/-7) 3 files modified
src/postorius/static/postorius/css/style.css (+3/-0) src/postorius/templates/postorius/lists/memberoptions.html (+1/-1) src/postorius/templates/postorius/user_subscription_preferences.html (+26/-6) |
||||
| To merge this branch: | bzr merge lp://staging/~bhavesh-goyal093/postorius/postorius-fix-ui | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Terri | Needs Information | ||
|
Review via email:
|
|||
Description of the change
Subscription Based Preferences page in postorius had wrongly aligned radio buttons which mislead the user to selecting incorrect choices and affected UI of postorius too.
Now the radio buttons are correctly aligned vertically rather than in an unordered fashion.
Also, the mailing list settings forms are now cleaner in the sense that earlier the width of class element 'well' was uneven which affected the overall look of postorius, now all forms are of same width and ui looks better in overall
To post a comment you must log in.
Unmerged revisions
- 207. By Bhavesh Goyal
-
Fixed Bug #1428646 (Updated Subscription Settings Forms UI)
- 206. By Bhavesh Goyal
-
Fixed Bug #1428966 which fixes postorius UI
- 205. By Bhavesh Goyal
-
Fixed postorius Bug #1428646 which updates the UI of Mailing list forms
- 204. By Bhavesh Goyal
-
Fixed UI Bug which had unaligned radio buttons in subsricption preferences tab
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
On my test setup using Firefox 37.0, this patch makes everything a bit too wide. This may be a browser-specific problem that needs a bit more finesse so that it appears consistent across platforms, or it's possible that the underlying code was fixed in one of the other updates merged since your original pull request. Could you test and see if the latest version fixes the issue you were seeing?