Merge lp://staging/~bhavesh-goyal093/postorius/fixed-nav-role-identification into lp://staging/postorius
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Merged at revision: | 211 | ||||||||
| Proposed branch: | lp://staging/~bhavesh-goyal093/postorius/fixed-nav-role-identification | ||||||||
| Merge into: | lp://staging/postorius | ||||||||
| Diff against target: |
71 lines (+8/-7) 2 files modified
src/postorius/templates/postorius/lists/summary.html (+1/-1) src/postorius/views/list.py (+7/-6) |
||||||||
| To merge this branch: | bzr merge lp://staging/~bhavesh-goyal093/postorius/fixed-nav-role-identification | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Terri | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Fixed Bug #1431474
Mailman offers different views for different roles in list nav bar. Earlier if the user had some access privileges for instance (a moderator), the the nav bar options which he got were the same as that of a normal subscriber. Manually opening the page from URL though allowed the user to access the privileged controls.
Now, a correct view is given for each of the member roles by changing the if condition of list_summary template which was earlier set to display nav options only for super users.
Also, Certain List Pages such as Held_messages were not accessible to moderators even though they have the right to access them and were given only to owners. Now The Permissions of the page are also corrected and set to moderators which hold actual control for those pages.
I'm rather amused that moderators weren't allowed access to the moderation pages. Silly!
This branch also includes giving moderators access to the mass subscribe interface, which they generally shouldn't have access to. Since it's a short fix to take that out, I'll probably just make the changes when I do the merge.