Merge lp://staging/~bhavesh-goyal093/postorius/feature-added-search-postorius-lists into lp://staging/postorius
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~bhavesh-goyal093/postorius/feature-added-search-postorius-lists |
| Merge into: | lp://staging/postorius |
| Diff against target: |
158 lines (+64/-3) 6 files modified
src/postorius/forms.py (+9/-0) src/postorius/static/postorius/css/style.css (+3/-0) src/postorius/templates/postorius/lists/confirm_removeall_subscribers.html (+5/-0) src/postorius/templates/postorius/lists/mass_removal.html (+5/-0) src/postorius/templates/postorius/lists/members.html (+10/-1) src/postorius/views/list.py (+32/-2) |
| To merge this branch: | bzr merge lp://staging/~bhavesh-goyal093/postorius/feature-added-search-postorius-lists |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Terri | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Search is regarded as an important function for any list. The postorius lists earlier had no such function in members list page. Thus for large lists, it was difficult for list maintainer to search for a particular member in such lists. Even with Find In Page Browser function, it doesn't allow to search among whole lists across different pages and just highlights the results merely reducing the effort of going through the whole list.
Now The Members list can be filtered based on email address and certain functions such as getting all addresses starting with certain keywords and getting addresses containing some specific keywords can also be performed using the search box implemented in members list page.
Unmerged revisions
- 214. By Bhavesh Goyal
-
Merged Updations
- 213. By Bhavesh Goyal
-
Sanitization for form input data
- 212. By Bhavesh Goyal
-
Added Page Titles for Mass Removal
- 211. By Bhavesh Goyal
-
pep8 minor fixes
- 210. By Bhavesh Goyal
-
Merged Updations
- 209. By Bhavesh Goyal
-
Improved Indentations
- 208. By Bhavesh Goyal
-
Feature Implemented: Added Search Functionality in postorius Members List
- 207. By Bhavesh Goyal
-
Fixed Bug #1428646 (Updated Subscription Settings Forms UI)
- 206. By Bhavesh Goyal
-
Fixed Bug #1428966 which fixes postorius UI
- 205. By Bhavesh Goyal
-
Fixed postorius Bug #1428646 which updates the UI of Mailing list forms
This looks like a useful feature, but I believe this needs some more careful validation of the search string. Could you double-check that you're following best practices since the search string is being displayed in the page?