upstart

Merge lp://staging/~bfiller/upstart/desktop-mode into lp://staging/ubuntu/trusty/upstart

  1. desktop-mode
  2. Merge into trusty
Proposed by Bill Filler
Status: Rejected
Rejected by: Steve Langasek
Proposed branch: lp://staging/~bfiller/upstart/desktop-mode
Merge into: lp://staging/ubuntu/trusty/upstart
Diff against target: 13 lines (+3/-0)
1 file modified
debian/user-conf/xsession-init.conf (+3/-0)
To merge this branch: bzr merge lp://staging/~bfiller/upstart/desktop-mode
Reviewer Review Type Date Requested Status
Steve Langasek Disapprove
Dimitri John Ledkov Pending
Review via email: mp+212075@code.staging.launchpad.net

Description of the change

set global env var DESKTOP_MODE needed by touch apps when running on non-touch sessions like the desktop

To post a comment you must log in.
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Change looks fine, but would like someone from the foundations team to review this as well.

Just to know, are we able to change the variable name or it is already being used by our applications?

Revision history for this message
Steve Langasek (vorlon) wrote :

Per discussion on IRC, we should do this differently by having apps detect an existing feature of the X environment (e.g., $DISPLAY being set) instead of setting another variable.

review: Disapprove

Unmerged revisions

1546. By Bill Filler

set DESKTOP_MODE env var on all session but ubuntu-touch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: