Merge lp://staging/~beuno/wikkid/fixes-on-a-plane into lp://staging/wikkid
Proposed by
Martin Albisetti
| Status: | Merged |
|---|---|
| Merged at revision: | 41 |
| Proposed branch: | lp://staging/~beuno/wikkid/fixes-on-a-plane |
| Merge into: | lp://staging/wikkid |
| Diff against target: |
137 lines (+54/-7) 6 files modified
wikkid/skin/default/edit.html (+3/-3) wikkid/skin/default/static/default.css (+14/-3) wikkid/tests/views/__init__.py (+1/-0) wikkid/tests/views/test_edit.py (+29/-0) wikkid/twistedserver.py (+2/-1) wikkid/view/edit.py (+5/-0) |
| To merge this branch: | bzr merge lp://staging/~beuno/wikkid/fixes-on-a-plane |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Penhey | Approve | ||
| Paul Hummer (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
I did a bunch of stuff on the plane:
* Edit pages now show a better title
* Added a test for the new edit page titles
* A few layout tweaks to the editing page
* Show a clickable URL when starting up
To post a comment you must log in.
Revision history for this message
| Martin Albisetti (beuno) wrote | # |
Revision history for this message
| Tim Penhey (thumper) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
These changes look good. I see your comment about setting the host. Yes, in my paste branch, we'll be able to set the host. Unfortunately, I need to fiddle more with it before I'm ready to propose for merge myself (and fiddle with it a lot).
Anyway, back from that tangent, these changes look good to me.