loggerhead

Merge lp://staging/~beuno/loggerhead/export-tarball into lp://staging/loggerhead

  1. export-tarball
  2. Merge into trunk-rich
Proposed by Martin Albisetti
Status: Rejected
Rejected by: Robert Collins
Proposed branch: lp://staging/~beuno/loggerhead/export-tarball
Merge into: lp://staging/loggerhead
Diff against target: 205 lines (+56/-6)
8 files modified
.bzrignore (+1/-0)
loggerhead/apps/branch.py (+9/-3)
loggerhead/config.py (+3/-0)
loggerhead/controllers/__init__.py (+3/-1)
loggerhead/controllers/download_ui.py (+27/-0)
loggerhead/controllers/revision_ui.py (+2/-1)
loggerhead/history.py (+7/-0)
loggerhead/templates/revision.pt (+4/-1)
To merge this branch: bzr merge lp://staging/~beuno/loggerhead/export-tarball
Reviewer Review Type Date Requested Status
xaav (community) Needs Information
Robert Collins Needs Fixing
Review via email: mp+52797@code.staging.launchpad.net

Description of the change

This adds some basic support for exporting tarballs of revisions.
It also allows excluding this feature by running BranchWSGIApp with allow_tarballs=False.

There are 2 more things I can think to add to this, but I've decided to defer that work after this lands:
- Allow specifying the cache dir
- Allow specifying zip or tarballs

To post a comment you must log in.
lp://staging/~beuno/loggerhead/export-tarball updated
432. By Martin Albisetti

Allow conditionally exporting tarballs, now with 300% less cruft.

Revision history for this message
Robert Collins (lifeless) wrote :

Cache directory seems like a bad idea to me - will create stuff we have to clean up, and either the tarball is cheap enough to make that its ok to do it live (at all), or its too expensive and shouldn't be enabled on a given server.

review: Needs Fixing
Revision history for this message
xaav (xaav) wrote :

@beuno How is this coming along?

review: Needs Information
Revision history for this message
Martin Albisetti (beuno) wrote :

I need to re-work this patch. Proper support for this has landed in bzrlib, so now I need to make use of that, and also make sure we either have a fall-back for older versions (unlikely, lots of work and hackish) or only display the option if it's supported.
Hope to get back to this after the Natty release craze dies down.

Revision history for this message
xaav (xaav) wrote :

@beuno When (approximately) is this going to be ready?

Revision history for this message
xaav (xaav) wrote :

Please see https://answers.launchpad.net/bzr/+question/159205

Revision history for this message
Robert Collins (lifeless) wrote :

I'd like us to stream it directly to the client.

Making the tarball even just in-memory, and then serving it adds the generation time to the overall delivery time: our load balancing software will timeout connections for non-trivial projects if we do it that way.

Revision history for this message
Martin Albisetti (beuno) wrote :

Geoff, see: https://code.launchpad.net/~jelmer/bzr/export-tgz-711226/+merge/53235

Revision history for this message
Robert Collins (lifeless) wrote :

I'm rejecting this branch - xaav's approach will work a lot better.

Revision history for this message
Robert Collins (lifeless) wrote :

https://code.launchpad.net/~xaav/loggerhead/export-tarball/+merge/63931 is the other approach.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches