Canonical Click Reviewers tools (obsolete)

Merge lp://staging/~beuno/click-reviewers-tools/remove-namespace-checks into lp://staging/click-reviewers-tools

  1. remove-namespace-checks
  2. Merge into trunk
Proposed by Martin Albisetti
Status: Merged
Approved by: Jamie Strandboge
Approved revision: 350
Merged at revision: 350
Proposed branch: lp://staging/~beuno/click-reviewers-tools/remove-namespace-checks
Merge into: lp://staging/click-reviewers-tools
Diff against target: 246 lines (+0/-211)
2 files modified
clickreviews/cr_lint.py (+0/-72)
clickreviews/tests/test_cr_lint.py (+0/-139)
To merge this branch: bzr merge lp://staging/~beuno/click-reviewers-tools/remove-namespace-checks
Reviewer Review Type Date Requested Status
Jamie Strandboge (community) Approve
Review via email: mp+246336@code.staging.launchpad.net

Description of the change

Remove checks that validate namespaces and email addresses, those are better suited for the store, which knows the information about the uploading user.

To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Looks good. Thanks!

review: Approve
Revision history for this message
Daniel Holbach (dholbach) wrote :

Shall I upload a new release to the archive and backport it to the SDK PPA?

Revision history for this message
Martin Albisetti (beuno) wrote :

On Wed, Jan 14, 2015 at 9:01 AM, Daniel Holbach
<email address hidden> wrote:
> Shall I upload a new release to the archive and backport it to the SDK PPA?

Yes please and thank you!

--
Martin

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches