Checkbox Provider - Base

Merge ~bettyl/plainbox-provider-checkbox:add-after-suspend-manual-thunderbolt-thumderbolt3-tests into plainbox-provider-checkbox:master

  1. Git
  2. lp:~bettyl/plainbox-provider-checkbox
  3. add-after-suspend-manual-thunderbolt-thumderbolt3-tests
  4. Merge into master
Proposed by Betty Lin
Status: Merged
Approved by: Jonathan Cave
Approved revision: 015a9a7cd030f438923253c6d1e176fb41f0e627
Merged at revision: 8b02e63676ab10521cd258c2b24463bd36a1a698
Proposed branch: ~bettyl/plainbox-provider-checkbox:add-after-suspend-manual-thunderbolt-thumderbolt3-tests
Merge into: plainbox-provider-checkbox:master
Diff against target: 124 lines (+63/-0)
2 files modified
units/thunderbolt/jobs.pxu (+30/-0)
units/thunderbolt/test-plan.pxu (+33/-0)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Approve
Betty Lin (community) Needs Resubmitting
Review via email: mp+368638@code.staging.launchpad.net

Description of the change

I have tested this in a stock Ubuntu 18.04 with adding "after-suspend-thunderbolt-cert" to somerville-iev-full.pxu.
When I do:
$ checkbox-cli list-bootstrapped com.canonical.ce::somerville-iev-full
The thunderbolt/thunderbolt3 related jobs will be listed:
com.canonical.certification::after-suspend-manual-thunderbolt/insert
com.canonical.certification::after-suspend-manual-thunderbolt/storage-test
com.canonical.certification::after-suspend-manual-thunderbolt/remove
com.canonical.certification::after-suspend-manual-thunderbolt3/insert
com.canonical.certification::after-suspend-manual-thunderbolt3/storage-test
com.canonical.certification::after-suspend-manual-thunderbolt3/remove

To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

Although this will probably work as you have shown in your testing, I think it might be sensible not to rely on the after-suspend flags in this case.

The depends fields in the jobs are trying to ensure the jobs are run in a series with the storage-test and remove jobs depending on the insert job.

For example after-suspend-manual-thunderbolt/storage-test should have a depends field identifying after-suspend-manual-thunderbolt/insert. I think I might consider using a "sibling" job in this case.

The test plan modifications are fine.

review: Needs Fixing
Revision history for this message
Betty Lin (bettyl) wrote :

@Jonathan

I add the sibling job, please take a look.
Also, I tested them, here is the test report:
https://certification.canonical.com/hardware/201810-26511/submission/145268/test-results/

I just tried thunderbolt3, I believe that thunderbolt will get the same result, thanks!

review: Needs Resubmitting
Revision history for this message
Jonathan Cave (jocave) wrote :

Thanks this is very close to what I was thinking of. One change needed however, can you add an (extra) depends on the job suspend/suspend_advanced to make sure these occur after the suspend event.

Revision history for this message
Betty Lin (bettyl) wrote :

@Jonathan

Since thunderbolt/storage-test, thunderbolt/remove, hunderbolt3/storage-test, thunderbolt3/remove depend on thunderbolt/insert and thunderbolt3/insert, I only add suspend/suspend_advanced to them.

Test report:
https://certification.canonical.com/hardware/201810-26511/submission/145321/

review: Needs Resubmitting
Revision history for this message
Jonathan Cave (jocave) wrote :

Great, thanks for working through the revisions with me.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches