Code review comment for lp://staging/~benoit.garret/tomdroid/storage-redesign

Revision history for this message
Benoit Garret (benoit.garret) wrote :

> Only items remaining:
> * do you have an SVG source for your refresh (sync) icon (for data/icon-src/)?
> what is it license?

I picked the icon in android git (http://android.git.kernel.org/), I don't know what license it is published under.
You can find it here: http://android.git.kernel.org/?p=platform/frameworks/base.git;a=blob;f=core/res/res/drawable/ic_menu_refresh.png;h=77d70dd4f0534271b71ef4eb87f5a7a917d944fa;hb=HEAD

> * I used grayscaled tango icons so far, do you like tango's action/view-
> refresh: http://commons.wikimedia.org/wiki/File:View-refresh.svg ? If not, its
> ok, I *really* don't mind keeping yours, I'm just being a consistency freak ;)

I'm fine with your icon, the one I put was merely a placeholder before finding something that was more consistent with the other ones in Tomdroid.

And I agree with you, consistency should be enforced as much as we can.

« Back to merge proposal