Launchpad itself

Merge lp://staging/~benji/launchpad/bug-771239 into lp://staging/launchpad

  1. bug-771239
  2. Merge into devel
Proposed by Benji York
Status: Merged
Approved by: Benji York
Approved revision: no longer in the source branch.
Merged at revision: 12992
Proposed branch: lp://staging/~benji/launchpad/bug-771239
Merge into: lp://staging/launchpad
Diff against target: 35 lines (+16/-7)
1 file modified
lib/lp/registry/javascript/structural-subscription.js (+16/-7)
To merge this branch: bzr merge lp://staging/~benji/launchpad/bug-771239
Reviewer Review Type Date Requested Status
j.c.sackett (community) Approve
Review via email: mp+60113@code.staging.launchpad.net

Commit message

[r=jcsackett][bug=771239] make the select all/select none links a little easier to read and use

Description of the change

In bug 771239 Huw points out that the "Select all"/"Select none" links
on the add/edit subscription form are too close together and could use a
separator (like "or"). This branch fixes that.

A screen shot demonstrating the change is at http://i.imgur.com/6DI0t.png.

The branch is free of lint.

To run the associated tests load
lib/lp/registry/javascript/tests/test_structural_subscription.html in a
browser.

To post a comment you must log in.
Revision history for this message
j.c.sackett (jcsackett) wrote :

This looks good to land.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.