Merge lp://staging/~ben-mendis/wicd/fix-exit-status into lp://staging/wicd/1.6
Proposed by
Ben the Pyrate
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 916 | ||||
| Proposed branch: | lp://staging/~ben-mendis/wicd/fix-exit-status | ||||
| Merge into: | lp://staging/wicd/1.6 | ||||
| Diff against target: |
27 lines (+6/-0) 1 file modified
cli/wicd-cli.py (+6/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~ben-mendis/wicd/fix-exit-status | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Pieter Leclerc (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Exit with a non-zero status (6) when a connection attempt does not succeed.
(This is my first time submitting a pull-request on LP, please let me know if I've gotten the process wrong.)
To post a comment you must log in.
Revision history for this message
| Pieter Leclerc (pieterleclerc-deactivatedaccount) wrote | # |
review:
Approve
Revision history for this message
| Pieter Leclerc (pieterleclerc-deactivatedaccount) wrote | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Tested.
Some comments (a list of the exit codes) would have been nice, and the output (always "done!") is not consistent with the exit code (0 or 6), but it is an improvement over the status quo so I've merged it already. Keep those improvements coming!