Merge lp://staging/~ben-kaehne/charm-helpers/nagios-status-fix into lp://staging/charm-helpers

Proposed by Benjamin Kaehne
Status: Merged
Merged at revision: 728
Proposed branch: lp://staging/~ben-kaehne/charm-helpers/nagios-status-fix
Merge into: lp://staging/charm-helpers
Diff against target: 12 lines (+1/-1)
1 file modified
charmhelpers/contrib/charmsupport/nrpe.py (+1/-1)
To merge this branch: bzr merge lp://staging/~ben-kaehne/charm-helpers/nagios-status-fix
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
charmers Pending
Review via email: mp+313918@code.staging.launchpad.net

Description of the change

Fixes bug lp#1631170 - nagios check marks services as not running when they are

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

Can you confirm that using -e does what we want under both Trusty (upstart) and Xenial (systemd)?

review: Needs Information
Revision history for this message
Jill Rouleau (jillrouleau) wrote :

Sorry for the delay in responding. Testing with percona-cluster, this option gives the expected/desired behaviour on xenial. (/usr/local/lib/nagios/plugins/check_status_file.py is looking for any instance of OK, CRITICAL, WARNING, UNKNOWN in the result.)

https://pastebin.canonical.com/184202/

Revision history for this message
Stuart Bishop (stub) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches