Merge lp://staging/~ben-a/u1db/fixes--1262956 into lp://staging/u1db
Proposed by
B Carrillo
| Status: | Rejected |
|---|---|
| Rejected by: | dobey |
| Proposed branch: | lp://staging/~ben-a/u1db/fixes--1262956 |
| Merge into: | lp://staging/u1db |
| Diff against target: |
17 lines (+3/-4) 1 file modified
u1db/sync.py (+3/-4) |
| To merge this branch: | bzr merge lp://staging/~ben-a/u1db/fixes--1262956 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| dobey (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
avoids double iteration
To post a comment you must log in.
Revision history for this message
| dobey (dobey) wrote | # |
Unmerged revisions
- 444. By B Carrillo
-
Avoid double iteration
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This change results in 25 tests failing. You can run the tests with: (mkdir -p build && cd build && cmake .. && make check)
These tests will have to not fail, and it would be nice if there were a way to test this specific change as well.