Merge lp://staging/~bcsaller/pyjuju/subordinate-removes into lp://staging/pyjuju
Status: | Work in progress |
---|---|
Proposed branch: | lp://staging/~bcsaller/pyjuju/subordinate-removes |
Merge into: | lp://staging/pyjuju |
Diff against target: |
550 lines (+264/-43) 11 files modified
juju/control/destroy_service.py (+2/-2) juju/control/remove_relation.py (+5/-3) juju/control/tests/test_destroy_service.py (+18/-4) juju/control/tests/test_remove_relation.py (+2/-2) juju/hooks/tests/test_invoker.py (+2/-0) juju/lib/testing.py (+3/-3) juju/state/hook.py (+9/-3) juju/state/tests/test_service.py (+78/-22) juju/unit/lifecycle.py (+64/-0) juju/unit/tests/test_lifecycle.py (+76/-2) juju/unit/workflow.py (+5/-2) |
To merge this branch: | bzr merge lp://staging/~bcsaller/pyjuju/subordinate-removes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Engineering | Pending | ||
Review via email:
|
Description of the change
Destroying a subordinate shouldn't result in tracebacks
Destroying a subordinate service after destroying its primary services results in a traceback
This patch corrects this. The associated test also previously failed to exercise all the needed
behavior to demonstrate this, which is corrected as well.
Unmerged revisions
- 543. By Benjamin Saller
-
missing import
- 542. By Benjamin Saller
-
missing import
- 541. By Benjamin Saller
-
catch another async failure location
- 540. By Benjamin Saller
-
verify unit state removal on subordinate suicide
- 539. By Benjamin Saller
-
move ports handling to another branch
- 538. By Benjamin Saller
-
merge trunk
- 537. By Benjamin Saller
-
typo
- 536. By Benjamin Saller
-
remove print
- 535. By Benjamin Saller
-
add back in subordinate removal, this will have to change to honor the normal flow control model later. When stop hooks are properly added this will also need another review
- 534. By Benjamin Saller
-
change arg. order for error message
Please take a look.