Merge lp://staging/~bcsaller/juju-gui/renderBundles3 into lp://staging/juju-gui/experimental

Reviewers: mp+183287_code.launchpad.net,

Message:
Please take a look.

Description:
Render Bundles

Re-propose of render bundles with additional changes requested
during feedback. This has some additional better testing around
the bundle module and lays out the pattern for a later refactoring
to try and share more code between Service and Bundle modules down the
road as we have time.

https://code.launchpad.net/~bcsaller/juju-gui/renderBundles3/+merge/183287

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/13447043/

Affected files:
   A [revision details]
   M app/app.js
   M app/assets/javascripts/d3-components.js
   M app/modules-debug.js
   A app/views/topology/bundle.js
   M app/views/topology/relation.js
   M app/views/topology/service.js
   M app/views/topology/topology.js
   M docs/d3-component-framework.rst
   A test/data/wp-deployer.yaml
   M test/index.html
   A test/test_bundle_module.js
   M test/test_topology.js
   M undocumented

The previous version at https://codereview.appspot.com/13361043/ already
has a +1, need one more, most likely from rick who has the feedback
asking for some of the changes here.

https://codereview.appspot.com/13447043/

LGTM with trivial

https://codereview.appspot.com/13447043/diff/1/app/views/topology/bundle.js
File app/views/topology/bundle.js (right):

https://codereview.appspot.com/13447043/diff/1/app/views/topology/bundle.js#newcode330
app/views/topology/bundle.js:330: @method panToCenter
match earlier comments, two spaces, closing */ back a bit.

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js#newcode63
app/views/topology/service.js:63:
comments alignment

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js#newcode463
app/views/topology/service.js:463: ZP = '.zoom-plane',
extra space not required here

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js#newcode497
app/views/topology/service.js:497: yuiNode = Y.Node(node);
same

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js#newcode516
app/views/topology/service.js:516: box = d3.select(node).datum();
extra space

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js#newcode1143
app/views/topology/service.js:1143: Pans the environment view to the
center all the services on the canvas.
now there's no space before the text

https://codereview.appspot.com/13447043/diff/1/docs/d3-component-framework.rst
File docs/d3-component-framework.rst (right):

https://codereview.appspot.com/13447043/diff/1/docs/d3-component-framework.rst#newcode122
docs/d3-component-framework.rst:122: attribute which defaults to true.
When false events will not be bound and this
When false <add comma>

https://codereview.appspot.com/13447043/

Thanks for the review, followed up on all this, as noted by errors
introduced by make prep, not design.

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/13447043/diff/1/app/views/topology/service.js#newcode63
app/views/topology/service.js:63:
On 2013/08/31 03:31:08, rharding wrote:
> comments alignment

Whole classes of errors introduced by make prep, I thought things were
basically working but it sometimes shifts things around without me
noticing, thanks.

https://codereview.appspot.com/13447043/

*** Submitted:

Render Bundles

Re-propose of render bundles with additional changes requested
during feedback. This has some additional better testing around
the bundle module and lays out the pattern for a later refactoring
to try and share more code between Service and Bundle modules down the
road as we have time.

R=benjamin.saller, rharding
CC=
https://codereview.appspot.com/13447043

https://codereview.appspot.com/13447043/