lp://staging/~bcsaller/juju-gui/framework-docs

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 261

Juju GUI Hackers: Pending requested 2012-11-28

Diff: 266 lines (+244/-0)

2 files modified

docs/d3-component-framework.rst (+242/-0)
docs/index.rst (+2/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1083797: d3-components.js does not have usage documentation

High

Fix Released

Link a bug report

Related blueprints

261. By Benjamin Saller on 2012-11-28

merge Nicola's doc changes, thanks

260. By Benjamin Saller on 2012-11-28

initial pass at component doc

259. By Madison Scott-Clary on 2012-11-27

Charm panel border improvements

From Matt C.: Shadow should be darker on darker areas in the panel (such as the charm name and search result headings), and the border should extend all the way down to the bottom of the view (was 1px short).

Per UX review, colors updated and inset box-shadow on bottom.

R=
CC=
https://codereview.appspot.com/6855049

258. By Francesco Banconi on 2012-11-27

Tests mutating URL and not removing test nodes.

One of the hotkeys tests mutated the URL.
Both tests in that test case also failed when run
in isolation, and some variables were unused.

Also fixed tests leaving elements in the DOM:
as a consequence, "Environmenton excellent provider"
was visible at the top of the page after a test run.
Now the container used by those tests is removed
after each test is run. Also removed an XXX saying
that removing the elements in afterEach can be
problematic. I've tried to reproduce the erroneus
behavior described, running the test suite several
times, without success. Anyway, removing in afterEach
what was created in beforeEach is something we do
everywhere in the tests. So, that XXX confused me
a bit, any hint?

To avoid flickering in the test page, I tried to
hide the nodes used by tests where possible.

R=
CC=
https://codereview.appspot.com/6856075

257. By Nicola Larosa on 2012-11-26

Compute documentation statistics.

Count the total number of YUIDoc documentation lines by
enhancing the output of the "bin/lint-yuidoc" command.

R=benji, gary.poster
CC=
https://codereview.appspot.com/6845085

256. By Benji York on 2012-11-23

Remove "requires" properties.

The minification process does not read the "requires" parameters defined in
"all-app-debug.js". This parameter should be defined in each custom yui object
that uses some kind of internal or external requirement. The sole use of
"all-app-debug.js" is to define the fullpath of the file that defines a given
module.

This patch removes all the existing "requires" properties from
"all-app-debug.js" and add then where they are needed.

R=
CC=
https://codereview.appspot.com/6845084

255. By Madison Scott-Clary on 2012-11-21

Fix initial creation of subordinates.

When creating a subordinate service initially, it was not being laid out properly by the pack layout, nor was it seeming to have drag events attached. Pack layout was expecting a value accessor function to return some number greater than zero when constructing its radius, which informs the x/y coordinates. Returning zero results in NaN for all three values, thus positioning the service at (0,0) and causing drag events to fail when updating the service's coordinates with dx/dy + NaN. This branch fixes this by ensuring that zero is never returned as the node's value. This fix is quick and intended to make the UI function with the current layout algorithm. Future layout algorithms, if they're designed by hand, will need to keep this in mind as well.

R=benjamin.saller, bac
CC=
https://codereview.appspot.com/6856067

254. By Thiago Veronezi on 2012-11-20

application hotkeys

The user can hit alt+e to open the environment view and alt+s to focus the
charm search field.

R=matthew.scott, benjamin.saller
CC=
https://codereview.appspot.com/6849078

253. By Gary Poster on 2012-11-20

Add favicon, tweak Makefile

Added the juju icon as a favicon, and then got lost in Makefile tweaks. Makefile now does not do unnecessary work, and no longer hides commands with @ so that we can see when we reintroduce unnecessary work. Also switch from a Makefile comment about the node_modules to a message generated by the Makefile.

R=thiago
CC=
https://codereview.appspot.com/6842072

252. By Brad Crittenden on 2012-11-20

Fix overflow on charm name.

The sections in the charm search results pane are fixed at 70px high.
Due to the way we construct the name, and the fact the charm authors
can set the name to be anything they want, some names exceed the
allotted one-line and wreak havoc on the layout.

Obvious lesson learned: any element with a fixed height and
user-supplied data must account for overflow.

The deploy button placement was also fixed.

Matt C. has seen screenshots of the truncation and offered tweaks on
the vertical spacing which are incorporated here.

R=matthew.scott, thiago
CC=
https://codereview.appspot.com/6843082