Merge lp://staging/~bcsaller/juju-gui/component-modules into lp://staging/~bcsaller/juju-gui/component-framework

Reviewers: mp+135272_code.launchpad.net,

Message:
Please take a look.

Description:
Example module for env view refactor

Looking to get more eyes on the way the module code is playing out. In
particular I'm much more interested in if the various parts fit together
in
a way that makes sense to people than an details of the impl.

The basic pattern is this

EnvironmentView has a Topology object which is a subclass of the
d3-component
stuff. The Env view binds modules to the topology (from
app/views/topology/).

The framework will look at each modules declarative structures for
events and
bind behavior. The basic cycle the view moves through then is

update() <- called on data change to recompute view models, things like
             position information.

render() <- draw the current scene. Render itself support the notion of
one
             time setup code and incremental rendering. For the most part

   scene mutation will happen in the event handlers though, those
   behaviors are facilitated by the framework but not controlled by
   it.

Modules attempt to aid in keeping inter-module code loosely coupled.
This is
done by encouraging use of custom YUI events. Module.events.yui is one
of the
event binding structures available from the framework, modules can
listen for
changes that may be of interest to other modules and fire events which
can
trigger handlers.

There isn't always a clean line between what should live in a module and
the
topology object itself but the rule of thumb is that if it can
reasonably go
in a module it should, the topology layer is mainly configuration and
coordination.

Looking forward to comments. Thanks.

https://code.launchpad.net/~bcsaller/juju-gui/component-modules/+merge/135272

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/6858045/

Affected files:
   M .bzrignore
   M Makefile
   M README
   A [revision details]
   M app/app.js
   A app/assets/images/back_triangle.png
   A app/assets/images/notifier-error.png
   M app/assets/javascripts/d3-components.js
   M app/assets/svgs/service_health_mask.svg
   M app/assets/svgs/service_module.svg
   A app/favicon.ico
   M app/index.html
   M app/models/models.js
   A app/modules-debug.js
   M app/modules.js
   M app/store/notifications.js
   M app/templates/charm-description.handlebars
   M app/templates/charm-pre-configuration.handlebars
   M app/templates/charm-search-result.handlebars
   A app/templates/notifier.handlebars
   M app/templates/overview.handlebars
   M app/views/charm-panel.js
   M app/views/charm.js
   M app/views/environment.js
   M app/views/notifications.js
   M app/views/service.js
   A app/views/topology/panzoom.js
   A app/views/topology/relation.js
   A app/views/topology/service.js
   A app/views/topology/topology.js
   A app/views/topology/viewport.js
   M app/views/unit.js
   M app/views/utils.js
   A app/widgets/notifier.js
   A bin/merge-files
   M docs/style-guide.rst
   M grunt.js
   A lib/merge-files.js
   M lib/server.js
   M lib/templates.js
   M lib/views/stylesheet.less
   M package.json
   M test-server.js
   M test/index.html
   M test/test_app.js
   A test/test_app_...

Please take a look.

https://codereview.appspot.com/6858045/

This created a huge delta, not sure why yet.

https://codereview.appspot.com/6858045/

On 2012/11/20 22:44:26, benjamin.saller wrote:
> This created a huge delta, not sure why yet.

Hi ben, i created another mp for this, but if you got a chance it would
be great if you could cleanup this mp and copy the comments over to it.

https://codereview.appspot.com/6858045/