Merge lp://staging/~bcim/bazaar-extractor/trunk-fix_bzr_whoami-jba into lp://staging/bazaar-extractor
Proposed by
Jacques-Etienne Baudoux
| Status: | Merged |
|---|---|
| Merged at revision: | 7 |
| Proposed branch: | lp://staging/~bcim/bazaar-extractor/trunk-fix_bzr_whoami-jba |
| Merge into: | lp://staging/bazaar-extractor |
| Diff against target: |
17 lines (+2/-1) 1 file modified
bzr-super-replay.rb (+2/-1) |
| To merge this branch: | bzr merge lp://staging/~bcim/bazaar-extractor/trunk-fix_bzr_whoami-jba |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Maxime Chambreuil (http://www.savoirfairelinux.com) | code review | Approve | |
| Joël Grand-Guillaume @ camptocamp | code review, no tests | Approve | |
|
Review via email:
|
|||
Description of the change
In my shell, bzr whoami was returning an extra newline. I had to chomp it.
Also, the command to put back the original whoami had to be quoted otherwise it's raising a shell error
To post a comment you must log in.
Revision history for this message
| Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote | # |
review:
Approve
(code review, no tests)
Revision history for this message
| Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) | # |
review:
Approve
(code review)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks ! LGTM