Merge lp://staging/~bcbc/wubi/lp694242 into lp://staging/wubi
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 288 | ||||
Proposed branch: | lp://staging/~bcbc/wubi/lp694242 | ||||
Merge into: | lp://staging/wubi | ||||
Diff against target: |
67 lines (+28/-0) 3 files modified
debian/changelog (+1/-0) src/wubi/application.py (+5/-0) src/wubi/backends/win32/backend.py (+22/-0) |
||||
To merge this branch: | bzr merge lp://staging/~bcbc/wubi/lp694242 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Dimitri John Ledkov | Pending | ||
Review via email: mp+160268@code.staging.launchpad.net |
Description of the change
This patch lets Wubi check whether Windows boots using EFI and, if so, prevents further processing.
The technique used is to examine the output of BCDEDIT for the presence of either bootmgfw.efi or winload.efi. I'm not entirely happy with this technique: ideally there would be a registry entry that is conclusive, but it works on BCDEDIT output I've seen from EFI systems ( http://
The check is performed prior to making any changes, so there is no need to download anything or uninstall once it has been determined that Windows boots in is in EFI mode.
I have tested this patch to confirm that it installs as usual on BIOS firmware (tested on Windows XP and Windows 8).
I haven't tested it on an EFI computer as I don't own one, but I created a test version that was identical except it searched for a string that happened to exist in my BCDEDIT output.
Ideally, we could build the wubi-r280.exe and then make a call for some community testing to confirm positive tests.
The wubi-13.
04-22 21:51 DEBUG WindowsBackend: EFI boot = False
or if using EFI the following lines:
04-22 21:51 DEBUG WindowsBackend: EFI boot = True
...
04-22 21:51 ERROR root: Wubi does not currently support EFI
There is also a Windows popup with the message: Wubi does not currently support EFI
I've tested this in VMWare Player with Windows installed in EFI mode and it works as expected.
There's no cleanup, downloading, etc. It detects EFI, gives a message and quits.