Merge lp://staging/~bbaqar/charms/trusty/plumgrid-edge/opsvm into lp://staging/~plumgrid-team/charms/trusty/plumgrid-edge/trunk

Proposed by Bilal Baqar
Status: Merged
Merged at revision: 25
Proposed branch: lp://staging/~bbaqar/charms/trusty/plumgrid-edge/opsvm
Merge into: lp://staging/~plumgrid-team/charms/trusty/plumgrid-edge/trunk
Diff against target: 363 lines (+79/-50)
8 files modified
hooks/ (+22/-14)
hooks/ (+10/-17)
hooks/ (+28/-1)
templates/kilo/00-pg.conf (+1/-0)
templates/kilo/plumgrid.conf (+1/-1)
unit_tests/ (+10/-7)
unit_tests/ (+5/-10)
unit_tests/ (+2/-0)
To merge this branch: bzr merge lp://staging/~bbaqar/charms/trusty/plumgrid-edge/opsvm
Reviewer Review Type Date Requested Status
Junaid Ali Approve
Javeria Khan Approve
Review via email:

Commit message

OPSVM Changes
Ticket: [SOL-830]

Description of the change

- Getting OPSVM IP from director relation
- Making OPSVM specific changes
- Cleaned code in various functions
- Added restart_on_change decorater function that restarts plumgrid service only when there has been any change in the configuration files
- Removed restart of plumgrid service when only two directors are available
- Fixed unit tests accordingly

To post a comment you must log in.
25. By Bilal Baqar

Cleaned code

26. By Bilal Baqar


27. By Bilal Baqar

Fixed lint and unit_tests

28. By Bilal Baqar

Improved dir ips string

29. By Bilal Baqar

Removed pkg purge in stop hook

30. By Bilal Baqar

fixing unit_test

Revision history for this message
Javeria Khan (javeria-ak) wrote :

Looks good to me functionally.

review: Approve
Revision history for this message
Junaid Ali (junaidali) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches