juju-deployer

Merge lp://staging/~barryprice/juju-deployer/resolve-yaml-warnings into lp://staging/juju-deployer

  1. resolve-yaml-warnings
  2. Merge into trunk
Proposed by Barry Price
Status: Merged
Approved by: Barry Price
Approved revision: 219
Merged at revision: 219
Proposed branch: lp://staging/~barryprice/juju-deployer/resolve-yaml-warnings
Merge into: lp://staging/juju-deployer
Diff against target: 75 lines (+21/-5)
2 files modified
deployer/tests/test_config.py (+11/-2)
deployer/tests/test_diff.py (+10/-3)
To merge this branch: bzr merge lp://staging/~barryprice/juju-deployer/resolve-yaml-warnings
Reviewer Review Type Date Requested Status
Benjamin Allot Approve
Canonical IS Reviewers Pending
Review via email: mp+391925@code.staging.launchpad.net

Commit message

Fix yaml.load() deprecation warnings by using SafeLoader, e.g.:

/home/barryprice/juju-deployer/deployer/tests/test_config.py:102: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Benjamin Allot (ballot) wrote :

LGTM.

Using safe_load lose the C binding optimization but is easier to read and maintain.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 219

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches