Juju Charms Collection
postgresql package

Merge lp://staging/~barryprice/charms/trusty/postgresql/more_frequent_backups into lp://staging/charms/trusty/postgresql

  1. Trusty Tahr (14.04)
  2. more_frequent_backups
  3. Merge into trunk
Proposed by Barry Price
Status: Merged
Merged at revision: 143
Proposed branch: lp://staging/~barryprice/charms/trusty/postgresql/more_frequent_backups
Merge into: lp://staging/charms/trusty/postgresql
Diff against target: 154 lines (+27/-19)
6 files modified
config.yaml (+2/-2)
hooks/postgresql.py (+1/-0)
scripts/pgbackup.py (+4/-5)
templates/pg_backup_job.tmpl (+17/-9)
templates/postgres.cron.tmpl (+2/-2)
tests/test_postgresql.py (+1/-1)
To merge this branch: bzr merge lp://staging/~barryprice/charms/trusty/postgresql/more_frequent_backups
Reviewer Review Type Date Requested Status
Review Queue (community) automated testing Approve
Stuart Bishop (community) Approve
Review via email: mp+283245@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Barry Price (barryprice) wrote :

As stub points out, there will usually be at least two backup files per run, potentially more (basically, $number_of_databases +1 for globals).

So the pruning of old backups needs some work here, I'm setting this to WIP for now.

lp://staging/~barryprice/charms/trusty/postgresql/more_frequent_backups updated
145. By Barry Price

Another attempt at getting the DB deletions correct

146. By Barry Price

Correct syntax

Revision history for this message
Stuart Bishop (stub) wrote :

Looks good.

review: Approve
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/2273/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

The results (PASS) are in and available here: http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/2252/

review: Approve (automated testing)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: