Merge ~barryprice/charm-canonical-livepatch/+git/canonical-livepatch-charm:master into ~livepatch-charmers/charm-canonical-livepatch:master

Proposed by Barry Price
Status: Merged
Approved by: Barry Price
Approved revision: 62416fa29784df12e2a9842449ae5673dbe8f997
Merged at revision: 6308443772e8c506cde9b2b61caec86c443cae6f
Proposed branch: ~barryprice/charm-canonical-livepatch/+git/canonical-livepatch-charm:master
Merge into: ~livepatch-charmers/charm-canonical-livepatch:master
Diff against target: 187 lines (+90/-54)
1 file modified
files/check_canonical-livepatch.py (+90/-54)
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Review via email: mp+355822@code.staging.launchpad.net

Commit message

Clearer check output, and warn if the client output format changes (i.e. if checkState or patchState go away).

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Stuart Bishop (stub) wrote :

Seems ok. Some comments inline.

review: Approve
Revision history for this message
Stuart Bishop (stub) wrote :

Yup, but see comments.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 6308443772e8c506cde9b2b61caec86c443cae6f

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches