piston-mini-client

Merge lp://staging/~barry/piston-mini-client/lp1077083 into lp://staging/piston-mini-client

  1. lp1077083
  2. Merge into trunk
Proposed by Barry Warsaw
Status: Merged
Merged at revision: 65
Proposed branch: lp://staging/~barry/piston-mini-client/lp1077083
Merge into: lp://staging/piston-mini-client
Diff against target: 165 lines (+44/-27)
6 files modified
README (+1/-2)
doc/index.rst (+2/-2)
piston_mini_client/auth.py (+28/-16)
piston_mini_client/tests/test_auth.py (+0/-5)
piston_mini_client/tests/test_serializers.py (+12/-1)
setup.py (+1/-1)
To merge this branch: bzr merge lp://staging/~barry/piston-mini-client/lp1077083
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Review via email: mp+135449@code.staging.launchpad.net

Description of the change

Switches from the long abandoned and not-Python-3-compatible python-oauth library to the well-supported-upstream and Python 3 compatible python-oauthlib library. Fixes a bogus dictionary order dependency which breaks Python 3.3. Re-enables a Python 3 test.

To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

Note that you will have some trouble testing this on today's Raring. The problem is that tox is not yet in Raring (it will soon land in Debian and then be synced to Raring), and the python-virtualenv version that is currently in Raring is not compatible with Python 3.3. This should be fixed upstream today and will make it into Ubuntu shortly thereafter.

To test this on Raring, your best bet is to install virtualenv from upstream git (where the Python 3.3 bug is fixed), create a Python 2.7 and separate Python 3.3 virtualenvs, install the dependencies into them (via pip), and then run nosetests into the virtualenv.

Hopefully by next week you'll be able to just run `tox -e py27,py33` in Raring.

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for this branch. Looks good to me, +1

review: Approve
Revision history for this message
Anthony Lenton (elachuni) wrote :

Thanks Barry!!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches