lazr.config

Merge lp://staging/~barry/lazr.config/lp1096512 into lp://staging/lazr.config

  1. lp1096512
  2. Merge into trunk
Proposed by Barry Warsaw
Status: Merged
Merged at revision: 6
Proposed branch: lp://staging/~barry/lazr.config/lp1096512
Merge into: lp://staging/lazr.config
Diff against target: 3559 lines (+1390/-1165)
21 files modified
_bootstrap/COPYRIGHT.txt (+0/-9)
_bootstrap/LICENSE.txt (+0/-54)
_bootstrap/bootstrap.py (+0/-77)
buildout.cfg (+0/-31)
distribute_setup.py (+546/-0)
ez_setup.py (+0/-241)
lazr/__init__.py (+12/-8)
lazr/config/__init__.py (+2/-1)
lazr/config/_config.py (+45/-46)
lazr/config/docs/NEWS.rst (+17/-0)
lazr/config/docs/fixture.py (+34/-0)
lazr/config/docs/usage.rst (+475/-590)
lazr/config/docs/usage_fixture.py (+27/-0)
lazr/config/interfaces.py (+3/-6)
lazr/config/tests/__init__.py (+0/-17)
lazr/config/tests/test_config.py (+205/-0)
lazr/config/version.txt (+1/-1)
setup.cfg (+9/-0)
setup.py (+14/-18)
src/lazr/config/NEWS.txt (+0/-15)
src/lazr/config/tests/test_docs.py (+0/-51)
To merge this branch: bzr merge lp://staging/~barry/lazr.config/lp1096512
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Gary Poster Pending
Gavin Panella Pending
LAZR Developers Pending
Review via email: mp+142715@code.staging.launchpad.net

Description of the change

Another port to Python 3. This one is just like the ports for lazr.smtptest and lazr.delegates. In fact, this depends on the branch for LP: #1096513 which Gavin has approved, but I haven't yet landed and released.

To test this, you'll need to create a virtualenv and install the branch for LP: #1096513 into it. Then you should be able to run the nosetests.

Just like the other two packages, I might have some post-porting fixups for the Sphinx documentation, but I'll clean all that up once this branch lands and I'm ready to do a PyPI release.

(Side note: not all of usage.rst could be retained due to printable repr differences between Python 2 and 3. Where necessary, such tests are moved to unittests, but coverage is still 99%-100% depending on the Python version used.)

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you for this update. I think this is fine to land, but I think there are changes in behaviour that deserve documentation:
   1. decode('ascii', 'strict'): appear to mean that someone upgrading might see more unicode errors raised.
   2. sorted category names: is nice to have, but different from the past.

review: Approve (code)
Revision history for this message
Barry Warsaw (barry) wrote :

On Jan 10, 2013, at 07:17 PM, Curtis Hovey wrote:

> 1. decode('ascii', 'strict'): appear to mean that someone upgrading might
> see more unicode errors raised.

Interestingly, the documentation says that only ASCII is acceptable but the
use of 'ignore' didn't enforce that, at least AFAICT.

> 2. sorted category names: is nice to have, but different from the past.

True. I thought about sorting in the test instead (you have to sort one place
or the other for doctest reproducibility). I mildly preferred to guarantee it
in the API.

Thanks for the review. I'll make sure the NEWS file and the release
announcement properly document these issues.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches