Merge lp://staging/~barry-mcgee/ubuntu-online-tour/optimsation into lp://staging/ubuntu-online-tour/14.04

Proposed by Barry McGee
Status: Merged
Merged at revision: 195
Proposed branch: lp://staging/~barry-mcgee/ubuntu-online-tour/optimsation
Merge into: lp://staging/ubuntu-online-tour/14.04
Diff against target: 4295 lines (+1666/-1487)
8 files modified
.bzrignore (+1/-0)
Gulpfile.js (+72/-0)
README (+32/-1)
css/style.min.css (+1/-0)
en/index.html (+16/-1486)
en/src/index.html (+1519/-0)
js/script.min.js (+4/-0)
package.json (+21/-0)
To merge this branch: bzr merge lp://staging/~barry-mcgee/ubuntu-online-tour/optimsation
Reviewer Review Type Date Requested Status
Anthony Dillon Approve
Review via email: mp+282165@code.staging.launchpad.net

Description of the change

* minify and concatenate the CSS
* minify and concatenate the JS
* compress the image files
* minify the HTML
* Update README to include Gulp instructions

To post a comment you must log in.
Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Wow ... 2.6MB to 109KB!! Awesome stuff.

But there are a few QA issues:
 - Shotwell the image view has errors
 - Folder icons are not showing up
 - The email layout does not float of flex anymore
 - Dash, apps do not float

review: Needs Fixing
201. By Barry McGee

Optimise images and remove UnCSS gulp task

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Looks good +1

review: Approve
202. By Barry McGee

Compress images

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches