Merge ~ballot/charm-prometheus-alertmanager/+git/charm-prometheus-alertmanager:log-level into charm-prometheus-alertmanager:master
Proposed by
Benjamin Allot
| Status: | Superseded |
|---|---|
| Proposed branch: | ~ballot/charm-prometheus-alertmanager/+git/charm-prometheus-alertmanager:log-level |
| Merge into: | charm-prometheus-alertmanager:master |
| Diff against target: |
103 lines (+61/-0) 3 files modified
src/config.yaml (+6/-0) src/reactive/alertmanager.py (+14/-0) src/tests/unit/test_reactive_alertmanager.py (+41/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Drew Freiberger (community) | Needs Fixing | ||
| BootStack Reviewers | Pending | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2021-01-27.
Commit message
Add the log-level config item
In order to easily debug, configuring the log-level of alertmanager can be handy.
The old default value of info (if not specified) is kept so an upgrade won't be bothered by the change.
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I'd like to see this charm go into a blocked state for an incorrectly configured log level value, and would appreciate seeing the values accepted for log-level in the config.yaml description.
I am also concerned that this change when upgrade-charm runs will restart the service (which is typically frowned upon) even if no configuration change is expected. Maybe the default should be a blank string, which equates to not setting a --log.level, which should keep the config file from being updated and the service from restarting based on service context change.