Merge lp://staging/~bac/zope.testing/list-tests into lp://staging/~launchpad/zope.testing/3.9.4-fork

Proposed by Brad Crittenden
Status: Merged
Approved by: Gary Poster
Approved revision: 31
Merged at revision: 30
Proposed branch: lp://staging/~bac/zope.testing/list-tests
Merge into: lp://staging/~launchpad/zope.testing/3.9.4-fork
Diff against target: 101 lines (+10/-11)
4 files modified
setup.py (+1/-1)
src/zope/testing/testrunner/find.py (+7/-7)
src/zope/testing/testrunner/formatter.py (+2/-2)
src/zope/testing/testrunner/listing.py (+0/-1)
To merge this branch: bzr merge lp://staging/~bac/zope.testing/list-tests
Reviewer Review Type Date Requested Status
Gary Poster (community) Approve
Review via email: mp+109007@code.staging.launchpad.net

Commit message

Make the testrunner output test.id() instead of str(test). Also allows tests to be discovered by pattern matching against the id property.

Description of the change

In Launchpad, some doctests are registered multiple times using different layers, etc. To the test runner they appear the same as they have the same id. Launchpad now gives them different ids but they still reference the same path, which is what the testrunner uses to report and discover tests.

This change causes the testrunner to output test.id() instead of str(test). It also allows tests to be discovered by pattern matching against the id property.

To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

Thank you Brad, and thanks for the cleanup along the way.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches