Code review comment for lp://staging/~bac/python-memcached/bug-974632

Revision history for this message
Brad Crittenden (bac) wrote :

Hi Sean, thanks for looking at this code.

Your comment confuses me a little because the approach you describe as your preferred solution seems to be what I've implemented, that is the readline() method is restored to never throw an exception while the unsafe do call a special method that can raise the exception. I called this new method _readline(), which could've been named better.

Perhaps there are call sites that use _expectvalue that I missed?

Anyway, I'll be happy to review the patch you produce.

« Back to merge proposal