Merge lp://staging/~bac/launchpad/bug-720147 into lp://staging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | Brad Crittenden |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 12967 |
| Proposed branch: | lp://staging/~bac/launchpad/bug-720147 |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
432 lines (+220/-32) 5 files modified
lib/lp/bugs/browser/bugtarget.py (+10/-10) lib/lp/bugs/interfaces/bug.py (+5/-1) lib/lp/bugs/model/bug.py (+14/-4) lib/lp/bugs/scripts/tests/test_bugnotification.py (+65/-13) lib/lp/bugs/tests/test_bug.py (+126/-4) |
| To merge this branch: | bzr merge lp://staging/~bac/launchpad/bug-720147 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Benji York (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
[r=benji][bug=720147] Correctly handle filtering for bugs created without the default status.
Description of the change
= Summary =
Bugs created with a status other than NEW were sending notifications for
subscriptions with other filters.
== Proposed fix ==
The bug notification was kicked off before the status change was
effected resulting in improper notices being sent.
== Pre-implementation notes ==
This work was done by Graham and Gary. I'm merely shepherding it
through review and landing in their absence.
I did, however, clean up some lint.
== Implementation details ==
As above.
== Tests ==
bin/test -vvm lp.bugs -t test_bugnotific
== Demo and Q/A ==
Create a structural subscription with filter with NEW status. Create a
bug with initial status of TRIAGE. Ensure notification is not sent.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
This branch looks good.
The only thought I had was that the part starting on line 13 of the diff
is a bit repetitive and I had to look very closely to see if it was
exactly the same pattern for each line or if one or more were subtly
different. However, I'm not sure my version is any better:
http://