Merge lp://staging/~bac/launchpad/bug-689719 into lp://staging/launchpad

Proposed by Brad Crittenden
Status: Merged
Approved by: Curtis Hovey
Approved revision: no longer in the source branch.
Merged at revision: 12091
Proposed branch: lp://staging/~bac/launchpad/bug-689719
Merge into: lp://staging/launchpad
Diff against target: 4702 lines (+51/-4129)
43 files modified
lib/canonical/launchpad/browser/__init__.py (+0/-3)
lib/canonical/launchpad/pagetests/basics/notfound-traversals.txt (+0/-1)
lib/canonical/launchpad/pagetitles.py (+0/-14)
lib/canonical/launchpad/security.py (+0/-25)
lib/canonical/launchpad/tests/test_poll.py (+0/-34)
lib/lp/registry/adapters.py (+2/-65)
lib/lp/registry/browser/configure.zcml (+0/-81)
lib/lp/registry/browser/person.py (+1/-50)
lib/lp/registry/browser/poll.py (+0/-469)
lib/lp/registry/browser/tests/poll-views.txt (+0/-134)
lib/lp/registry/browser/tests/poll-views_0.txt (+0/-92)
lib/lp/registry/browser/tests/test_breadcrumbs.py (+0/-20)
lib/lp/registry/browser/tests/test_poll.py (+0/-38)
lib/lp/registry/configure.zcml (+0/-103)
lib/lp/registry/doc/person-merge.txt (+26/-32)
lib/lp/registry/doc/poll-preconditions.txt (+0/-74)
lib/lp/registry/doc/poll.txt (+0/-140)
lib/lp/registry/doc/team-nav-menus.txt (+0/-3)
lib/lp/registry/interfaces/poll.py (+0/-500)
lib/lp/registry/model/person.py (+7/-3)
lib/lp/registry/model/poll.py (+0/-440)
lib/lp/registry/stories/team-polls/create-poll-options.txt (+0/-85)
lib/lp/registry/stories/team-polls/create-polls.txt (+0/-163)
lib/lp/registry/stories/team-polls/edit-options.txt (+0/-59)
lib/lp/registry/stories/team-polls/edit-poll.txt (+0/-97)
lib/lp/registry/stories/team-polls/vote-poll.txt (+0/-167)
lib/lp/registry/stories/team-polls/xx-poll-condorcet-voting.txt (+0/-229)
lib/lp/registry/stories/team-polls/xx-poll-confirm-vote.txt (+0/-89)
lib/lp/registry/stories/team-polls/xx-poll-results.txt (+0/-69)
lib/lp/registry/stories/team/xx-team-home.txt (+8/-15)
lib/lp/registry/templates/poll-edit.pt (+0/-34)
lib/lp/registry/templates/poll-index.pt (+0/-207)
lib/lp/registry/templates/poll-newoption.pt (+0/-36)
lib/lp/registry/templates/poll-portlet-details.pt (+0/-38)
lib/lp/registry/templates/poll-portlet-options.pt (+0/-46)
lib/lp/registry/templates/poll-vote-condorcet.pt (+0/-130)
lib/lp/registry/templates/poll-vote-simple.pt (+0/-141)
lib/lp/registry/templates/polloption-edit.pt (+0/-37)
lib/lp/registry/templates/team-index.pt (+0/-1)
lib/lp/registry/templates/team-newpoll.pt (+0/-25)
lib/lp/registry/templates/team-polls.pt (+7/-69)
lib/lp/registry/templates/team-portlet-polls.pt (+0/-56)
lib/lp/testing/factory.py (+0/-15)
To merge this branch: bzr merge lp://staging/~bac/launchpad/bug-689719
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email: mp+43840@code.staging.launchpad.net

Commit message

[r=sinzui][ui=none][bug=689719] Remove the Polls feature from Launchpad

Description of the change

= Summary =

Remove the polls feature from Launchpad.

== Proposed fix ==

Rip, rip, rip.

== Pre-implementation notes ==

Talks and querying with Curtis regarding existing data.

== Implementation details ==

N/A

== Tests ==

bin/test -vvm lp.registry

== Demo and Q/A ==

http://dev.launchpad.net/~ubuntu-team/+polls

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/browser/configure.zcml
  lib/lp/registry/adapters.py
  lib/lp/registry/templates/team-index.pt
  lib/lp/registry/browser/tests/test_breadcrumbs.py
  lib/canonical/launchpad/security.py
  lib/canonical/launchpad/pagetitles.py
  lib/lp/registry/templates/team-polls.pt
  lib/lp/registry/configure.zcml
  lib/lp/testing/factory.py
  lib/lp/registry/doc/person-merge.txt
  lib/lp/registry/stories/team/xx-team-home.txt
  lib/lp/registry/browser/person.py
  lib/lp/registry/model/person.py

These are all bogus.

./lib/canonical/launchpad/security.py
     742: E302 expected 2 blank lines, found 1
./lib/canonical/launchpad/pagetitles.py
      58: E302 expected 2 blank lines, found 3
      60: E301 expected 1 blank line, found 0
      69: E301 expected 1 blank line, found 0
      75: E301 expected 1 blank line, found 0
      81: E301 expected 1 blank line, found 0
      87: E301 expected 1 blank line, found 0
     100: E301 expected 1 blank line, found 0
     121: E302 expected 2 blank lines, found 1
     147: E302 expected 2 blank lines, found 1
     151: E302 expected 2 blank lines, found 1
     158: E302 expected 2 blank lines, found 1
     193: E302 expected 2 blank lines, found 1
     202: E302 expected 2 blank lines, found 1
     239: E302 expected 2 blank lines, found 1
     256: E302 expected 2 blank lines, found 1

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

We talked on IRC and agreed that "Conducting polls is no longer a feature in Launchpad" is awkward. We will use "Launchpad no longer support team polls".

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.