...

> === modified file 'lib/lp/registry/browser/sourcepackage.py'
> --- lib/lp/registry/browser/sourcepackage.py	2010-01-29 15:03:49 +0000
> +++ lib/lp/registry/browser/sourcepackage.py	2010-02-11 20:08:17 +0000

...

> @@ -349,3 +348,22 @@
>              'The project %s was linked to this source package.' %
>              upstream.displayname)
>          self.next_url = self.request.getURL()
> +
> +    @property
> +    def has_bugtracker(self):
> +        """Does the product have a bugtracker set?"""
> +        def getTrackerName(bugtracker):
> +            if bugtracker is None:
> +                return False
> +            else:
> +                return True
> +        product = self.context.productseries.product
> +        if product.official_malone:
> +            return True
> +        bugtracker = product.bugtracker
> +        if bugtracker is None:
> +            if product.project is not None:
> +                bugtracker = product.project.bugtracker
> +        if bugtracker is None:
> +            return False
> +        return True

I see that I underestimated the complexity of this connection. I think this
needs better test coverage. I think a test of a new factory-made product
that gets a project without a bug tracker will work. Change the
official_malone and bug tracker a few times to show that has_bugtracker
returns the expected state.

...

> === modified file 'lib/lp/registry/templates/sourcepackage-portlet-associations.pt'
> --- lib/lp/registry/templates/sourcepackage-portlet-associations.pt	2010-02-01 13:13:23 +0000
> +++ lib/lp/registry/templates/sourcepackage-portlet-associations.pt	2010-02-11 20:08:17 +0000
> @@ -5,37 +5,51 @@
>     omit-tag="">
>  
>    <div id="portlet-associations">
> -    <h2>Upstream associations</h2>
> +    <h2>Upstream connections</h2>

I am considering a similar portlet on the project page:
    Contributor connections

Is the title on this portlet clearer if it is:
    Upstream contributor connections
 
...

> +          <dl>
> +            <dt>
> +              <a tal:replace="structure series/fmt:link" />
> +            </dt>

We lost the link to change the linked series. This is needed by about 50
packages each release when the package is built from a new stable series.

We have a choice here: add an edit icon here:

    <a tal:replace="structure context/menu:overview/edit_packaging/fmt:icon" />

But I think the action will be more clear if we move it below because the user
may want to change the /project/ and series. See the end of this review.

> +            <dd title="Series branch"
> +                tal:define="bool series/branch">
> +              Branch:
> +              <metal:yes-no
> +                 use-macro="context/@@+base-layout-macros/yes-no" />
> +            </dd>
> +          </dl>

As I said on IRC, we need to show translations too...
...and you just showed me your fix in IRC. Fab.

>          </div>
>  
>          <ul class="horizontal">

I think we should move the link to edit the Packaging link to this list
where we can use a clear label: Change upstream project and series. As
we agreed on the phone, if the link should be different if the upstream
had never been set: Set upstream project and series.

And I see that the "Show upstream links" is missing its leading (i) icon.
Can you add that to the link?

...