lp://staging/~bac/charms/precise/juju-gui/expose-cookies

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/~juju-gui/charms/precise/juju-gui/trunk at revision 69

charmers: Pending requested 2013-06-18

Diff: 108 lines (+28/-4)

6 files modified

config.yaml (+10/-0)
config/config.js.template (+1/-0)
hooks/backend.py (+2/-1)
hooks/utils.py (+2/-1)
revision (+1/-1)
tests/test_utils.py (+12/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

70. By Brad Crittenden on 2013-06-18

Bump rev

69. By Brad Crittenden on 2013-06-18

Expose 'use-analytics' via the charm.

68. By Francesco Banconi on 2013-06-12

Charm test improvements.

This branch includes some improvements to
the charm testing infrastructure:

Strengthened the Juju implementation check by
introducing a new juju_version helper function.

Do not require the branch to be named "juju-gui"
anymore: the charm can be tested and deployed from
an arbitrary branch.

Updated documentation.

Added the .lbox.check file: now, before
proposing/submitting at least the lint check
and the unit tests must pass.

R=teknico, j.c.sackett
CC=
https://codereview.appspot.com/9714047

67. By Nicola Larosa on 2013-06-12

Add AGPL license and headers.

Add headers pointing to the AGPL license to almost all files,
and add the license text itself.

Sorry for the size, it's just comments, no behavior change.

R=matthew.scott, frankban
CC=
https://codereview.appspot.com/9836045

66. By Francesco Banconi on 2013-06-11

Fix the charmworld URL default value.

Missing trailing slash.

R=
CC=
https://codereview.appspot.com/10192043

65. By Francesco Banconi on 2013-06-10

Replace jitsu test with juju-test.

This branch makes juju-test the default test runner
for both the unit tests and the charm functional tests.

The charm test suite now supports both pyJuju and juju-core.

The tests dependencies are now installed in a virtualenv that
is automatically created and updated by the first test
executable (00-setup). This way we don't require the user
to install all the packages, and, moreover, we make the tests
ready to be run in the charm testing infrastructure.

When the charm is deployed during tests, a temporary repository
is created where the charm is copied and then deployed.
This way we achieve two important goals:
- the developer is not forced to manually set up a local
Juju repository where to branch the Juju GUI;
- the charm can be deployed even if it contains a virtualenv, i.e.
a directory with absolute symlinks (that's because the .venv dir
is not copied in the temp repo).

The tests/helpers.py and tests/deploy.py files will be eventually
replaced by similar tools provided by the juju testing harness.

Updated the documentation where required.

Fixed unit tests exit code.

Common commands (test/lint/clean etc.) can now be easily run
using make.

Nice to have, not included in this branch:
  - collect deployment test logs;
  - reintroduce a way to test the charm specifying a
    different juju-gui-source;
  - do not require the branch to be named "juju-gui".

PS: sorry for the diff, well over 1k loc :-/

R=
CC=
https://codereview.appspot.com/9874050

64. By Nicola Larosa on 2013-06-06

Fix backend unit tests.

Make the backend unit tests not expect any extra repositories.

R=frankban, bac
CC=
https://codereview.appspot.com/10020044

63. By Brad Crittenden on 2013-06-04

[TRIVIAL] Add .lbox for specifying the target

R=
CC=
https://codereview.appspot.com/10009043

62. By Brad Crittenden on 2013-06-04

Fix the discrepancy between dev and rel branches.

Changes that should've been submitted to the development branch of the gui
(lp:~juju-gui/charms/precise/juju-gui/trunk) were instead merged into the
release branch (lp:charms/juju-gui).

This branch merges those changes back into devel for on-going work. The
premature release will remain in place.

R=teknico
CC=
https://codereview.appspot.com/9975046

61. By Francesco Banconi on 2013-06-03

Take the juju API address from the environment

The charm now tries to retrieve the juju API
address from the hook context before parsing
the machiner agent file.

This way we take advantage of a change in juju-core
currently in review, which introduces the corresponding
functionality.

R=
CC=
https://codereview.appspot.com/9810044