Juju Charms Collection
buildbot-master package

Merge lp://staging/~bac/charms/oneiric/buildbot-master/initial into lp://staging/~yellow/charms/oneiric/buildbot-master/trunk

  1. Oneiric (11.10)
  2. initial
  3. Merge into trunk
Proposed by Brad Crittenden
Status: Merged
Approved by: Brad Crittenden
Approved revision: 7
Merged at revision: 7
Proposed branch: lp://staging/~bac/charms/oneiric/buildbot-master/initial
Merge into: lp://staging/~yellow/charms/oneiric/buildbot-master/trunk
To merge this branch: bzr merge lp://staging/~bac/charms/oneiric/buildbot-master/initial
Reviewer Review Type Date Requested Status
Benji York (community) code Approve
Review via email: mp+90468@code.staging.launchpad.net

Commit message

Initial version of buildbot-master charm.

Description of the change

Initial version of buildbot-master charm.

This branch has limitations. The relation hooks are not done.
The ssh key configuration is flaky.

You can use this charm to pass a full master.cfg file or to check out an entire buildbot configuration directory using bzr and a public branch.

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

Assuming I understand what's going on here, this looks good.

Here's one thing (the quoting) that needs to be fixed and then some other
things that may or may not need to be changed.

In the hooks scripts environment variables that may contain spaces should be
quoted. For example, if the BUILDBOT_DIR contains a space, this command would
fail:

    buildbot start $BUILDBOT_DIR

Line 21 of hooks/config-changed has a very long line (comment).

It looks like the hooks/relation-name-* files are just placeholders and can be
removed. Similarly for the provides/requires/peers entries in metadata.yaml.

Do we need all three of the configuration/master.cfg.* files? It looks like we
just need master.cfg.lp.

Are we done with the HANDOFF.txt file? Should it live somewhere else?

review: Approve (code)
Revision history for this message
Brad Crittenden (bac) wrote :

Thanks Benji. Good catch on the quoting of $VARS. My bash-fu is pretty bad.

The other comments are good as well and I'll do the clean up suggested.

lp://staging/~bac/charms/oneiric/buildbot-master/initial updated
7. By Brad Crittenden

Incorporated changes (some) from review

Subscribers

People subscribed via source and target branches

to all changes: