Maya

Merge lp://staging/~b-beelitz/maya/fix-1072534 into lp://staging/~elementary-apps/maya/trunk

  1. fix-1072534
  2. Merge into trunk
Proposed by Benjamin Beelitz
Status: Rejected
Rejected by: Cody Garver
Proposed branch: lp://staging/~b-beelitz/maya/fix-1072534
Merge into: lp://staging/~elementary-apps/maya/trunk
Diff against target: 24 lines (+6/-1)
1 file modified
Maya/Utils.vala (+6/-1)
To merge this branch: bzr merge lp://staging/~b-beelitz/maya/fix-1072534
Reviewer Review Type Date Requested Status
Cody Garver (community) Needs Fixing
Benjamin Beelitz (community) Approve
David Gomes (community) Needs Fixing
Review via email: mp+141187@code.staging.launchpad.net

Description of the change

The ICS Format must have an BEGIN VCALENDAR and END VCALENDAR and so on. With this patch the export should be correct and it worked to import in external tools like Google Calendar.

To post a comment you must log in.
Revision history for this message
David Gomes (davidgomes) wrote :

Needs fixing, you should use """ for strings with newlines.

review: Needs Fixing
Revision history for this message
Benjamin Beelitz (b-beelitz) wrote :

What do you mean with """?

Revision history for this message
David Gomes (davidgomes) wrote :

"""my string
with
newlines
is in here
hihiihihi"""

Revision history for this message
Benjamin Beelitz (b-beelitz) wrote :

;-) i will fix it soon

lp://staging/~b-beelitz/maya/fix-1072534 updated
389. By Benjamin Beelitz

Fix after review

390. By Benjamin Beelitz

Fix after review 2

Revision history for this message
Benjamin Beelitz (b-beelitz) wrote :

Fixed after review

review: Needs Resubmitting
Revision history for this message
Benjamin Beelitz (b-beelitz) :
review: Approve
Revision history for this message
Cody Garver (codygarver) wrote :

When I use "Export Calendar..." the result is missing the .ics extension.

review: Needs Fixing
Revision history for this message
David Gomes (davidgomes) wrote :

The code has been fixed in the meanwhile.

Unmerged revisions

390. By Benjamin Beelitz

Fix after review 2

389. By Benjamin Beelitz

Fix after review

388. By Benjamin Beelitz

Patch for 1072534, ICS Export failed

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches