update notifier

Merge lp://staging/~azzar1/update-notifier/livepatch-notification into lp://staging/update-notifier/ubuntu

  1. livepatch-notification
  2. Merge into ubuntu
Proposed by Andrea Azzarone
Status: Merged
Merged at revision: 910
Proposed branch: lp://staging/~azzar1/update-notifier/livepatch-notification
Merge into: lp://staging/update-notifier/ubuntu
Diff against target: 181 lines (+115/-1)
6 files modified
debian/systemd/update-notifier-livepatch.path (+6/-0)
debian/systemd/update-notifier-livepatch.service (+6/-0)
debian/update-notifier.install (+3/-0)
po/POTFILES.in (+1/-0)
src/Makefile.am (+6/-1)
src/livepatch.c (+93/-0)
To merge this branch: bzr merge lp://staging/~azzar1/update-notifier/livepatch-notification
Reviewer Review Type Date Requested Status
Brian Murray Needs Fixing
Sebastien Bacher Needs Information
Review via email: mp+329322@code.staging.launchpad.net

Commit message

Show livepatch notifications using update-notifier.

To post a comment you must log in.
lp://staging/~azzar1/update-notifier/livepatch-notification updated
917. By Andrea Azzarone

Fix debian/update-notifier.install

918. By Andrea Azzarone

Trigger the notification on EVENT=create too.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work, it looks good, one minor comment though
_("A LivePatch update
and
_("Canonical Livepatch"

shouldn't the spelling of Live(pP)atch be consistent between those strings?

review: Needs Information
lp://staging/~azzar1/update-notifier/livepatch-notification updated
919. By Andrea Azzarone

LivePatch -> Livepatch

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> Thank you for your work, it looks good, one minor comment though
> _("A LivePatch update
> and
> _("Canonical Livepatch"
>
> shouldn't the spelling of Live(pP)atch be consistent between those strings?

Fixed

lp://staging/~azzar1/update-notifier/livepatch-notification updated
920. By Andrea Azzarone

Add "usr/bin/livepatch-notification usr/lib/update-notifier/" to update-notifier.install

921. By Andrea Azzarone

Fix path to status file in systemd and upstart file.

Revision history for this message
Brian Murray (brian-murray) wrote :

I've only taken a brief look at this but did not some inconsistencies between LivePatch and Livepatch.

review: Needs Fixing
lp://staging/~azzar1/update-notifier/livepatch-notification updated
922. By Andrea Azzarone

LivePatch -> livepatch in sysmted and upstart files too.

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> I've only taken a brief look at this but did not some inconsistencies between
> LivePatch and Livepatch.

Fixed.

Revision history for this message
Brian Murray (brian-murray) wrote :

In Artful we are working on removing upstart jobs from packages and given that this merge proposal is against trunk / artful I don't think the upstart job should included.

If there is a desire to get livepatch support in update-notifier into Ubuntu 16.04 the upstart job doesn't also need to exist in Artful (I say this as an SRU team member).

review: Needs Fixing
lp://staging/~azzar1/update-notifier/livepatch-notification updated
923. By Andrea Azzarone

Remove upstart jobs conf files.

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> In Artful we are working on removing upstart jobs from packages and given that
> this merge proposal is against trunk / artful I don't think the upstart job
> should included.
>
> If there is a desire to get livepatch support in update-notifier into Ubuntu
> 16.04 the upstart job doesn't also need to exist in Artful (I say this as an
> SRU team member).

Fixed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: