Merge lp://staging/~azzar1/update-manager/fix-lp-1807900 into lp://staging/update-manager

Proposed by Andrea Azzarone
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://staging/~azzar1/update-manager/fix-lp-1807900
Merge into: lp://staging/update-manager
Diff against target: 96 lines (+31/-3)
2 files modified
UpdateManager/Dialogs.py (+24/-3)
UpdateManager/UpdateManager.py (+7/-0)
To merge this branch: bzr merge lp://staging/~azzar1/update-manager/fix-lp-1807900
Reviewer Review Type Date Requested Status
Sebastien Bacher Needs Information
Review via email: mp+366051@code.staging.launchpad.net

Commit message

Check if software-properties-livepatch.desktop is available to show (or not to show) the Livepatch settings button.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

The changes include some refactoring, you change the behaviour of the button in case livepatch is included in the label right (opening now on the livepatch tab while it was not doing it before) ? Is that described in the specification?

review: Needs Information
Revision history for this message
Andrea Azzarone (azzar1) wrote :

I asked mpt and that button should not open the Livepatch page. I'll update the MP ASAP.

Revision history for this message
Brian Murray (brian-murray) wrote :

Will somebody else be picking this up?

Revision history for this message
Sebastien Bacher (seb128) wrote :

Brian, yes, we will reassign to someone in desktop

Revision history for this message
Sebastien Bacher (seb128) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

Unmerged revisions

2851. By Andrea Azzarone

Check if software-properties-livepatch.desktop is available to show (or not to show) the Livepatch settings button.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: