Unity

Merge lp://staging/~azzar1/unity/round-gtk-scaling-to-closest-integer into lp://staging/unity

  1. round-gtk-scaling-to-closest-integer
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 4215
Proposed branch: lp://staging/~azzar1/unity/round-gtk-scaling-to-closest-integer
Merge into: lp://staging/unity
Diff against target: 21 lines (+2/-2)
1 file modified
unity-shared/UnitySettings.cpp (+2/-2)
To merge this branch: bzr merge lp://staging/~azzar1/unity/round-gtk-scaling-to-closest-integer
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
David Jordan (community) Approve
Review via email: mp+313459@code.staging.launchpad.net

Commit message

Round gtk scaling factor to closest integer.

Description of the change

Round gtk scaling factor to closest integer.

To post a comment you must log in.
Revision history for this message
Omer Akram (om26er) wrote :

What's the impact of this one ? Will scaling of 1.68 effectively result in 2X scaling ?

Revision history for this message
Andrea Azzarone (azzar1) wrote :

This will not affect unity scaling, neither text scaling. Just gtk
window scaling that is integer. So yes 1.68 will be 2.

On Fri, Dec 16, 2016 at 8:34 PM, Omer Akram <email address hidden> wrote:
> What's the impact of this one ? Will scaling of 1.68 effectively result in 2X scaling ?
> --
> https://code.launchpad.net/~azzar1/unity/round-gtk-scaling-to-closest-integer/+merge/313459
> You are the owner of lp:~azzar1/unity/round-gtk-scaling-to-closest-integer.
>
> Launchpad-Message-Rationale: Owner
> Launchpad-Message-For: azzar1
> Launchpad-Notification-Type: code-review
> Launchpad-Branch: ~azzar1/unity/round-gtk-scaling-to-closest-integer
> Launchpad-Project: unity

Revision history for this message
David Jordan (dmj726) wrote :

Will test shortly on 14" and 17" machines, though I expect to see some issues with text size, qt scaling, etc.

Revision history for this message
David Jordan (dmj726) wrote :

The sudden switch in scaling factor when the user manually picks say 1.68 is pretty jarring, and I'm not sure it would be readily understood why it's happening, especially when text size changes at each step.

Let's leave the manual scaling alone and just focus on defaulting to scales we can represent perfectly.

review: Needs Fixing
Revision history for this message
David Jordan (dmj726) wrote :

Actually, digging into this more, I'd say this is a minor improvement (moving the sudden, size increase to 1.5x instead of having the jump at 2x), so I'm definitely fine with this patch.

It's not a fix for bug #1649736 though.

review: Approve
Revision history for this message
Andrea Azzarone (azzar1) wrote :

Merged patch from https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1649736/comments/6

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Looks good, thanks.

review: Approve
Revision history for this message
David Jordan (dmj726) wrote :

Looks good to me!

Revision history for this message
Kai-Heng Feng (kaihengfeng) wrote :

Thanks for the patch!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.