Unity

Merge lp://staging/~azzar1/unity/lp-1154364 into lp://staging/unity

lp-1154364
Merge into trunk

Proposed by Andrea Azzarone on 2015-12-26

Status:

Needs review

Proposed branch:

lp://staging/~azzar1/unity/lp-1154364

Merge into:

lp://staging/unity

Diff against target:

52 lines (+16/-5)

1 file modified

unity-shared/SearchBar.cpp (+16/-5)

To merge this branch:

bzr merge lp://staging/~azzar1/unity/lp-1154364

High

Triaged

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2015-12-26
Unity Team		2015-12-26	Pending
Review via email: mp+281357@code.staging.launchpad.net

Commit message

Propose a fix for bug #1154364. Patch originally proposed by Prasad Somwanshi.

Description of the change

Make search wait timeout depend on the search text length.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-26:

PASSED: Continuous integration, rev:4068
http://jenkins.qa.ubuntu.com/job/unity-ci/1393/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-xenial-amd64-ci/43
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-xenial-armhf-ci/43
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-xenial-i386-ci/43

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/1393/rebuild

review: Approve (continuous-integration)

Revision history for this message

Mateusz Stachowski (stachowski-mateusz) on 2015-12-26:

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2016-03-08:

Add a new property for the max live search timeout and use live_search_wait() property instead of the default value.

In this way we can change tweak these values in other views, such as the SpreadFilter where we probably want to use different values (let's define good ones for that as well).

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2016-04-08:

Andrea, can you please check the comments here?