Merge lp://staging/~azzar1/unity/inverse-mouse-area-previews into lp://staging/unity/phablet

FAILED: Continuous integration, rev:546
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~andyrock/unity/inverse-mouse-area-previews/+merge/157557/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/310/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/311
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/311/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/310
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/186
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/186/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/186
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/700

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/310/rebuild

Hey, please move the calls to .clear() to an init() function in the TestCase

> Hey, please move the calls to .clear() to an init() function in the TestCase

Done.

PASSED: Continuous integration, rev:547
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/311/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/312
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/312/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/311
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/187
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/187/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/187
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/701

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/311/rebuild

What is the problem with the InverseMouseArea?

Also, shouldn't this be a separate tst_DashContent test?

InverseMouseArea fails to detect click outside its area in the test, maybe
a problem with event filtering?

Why? we are testing dash previews here.
Il giorno 08/apr/2013 01:44, "Michał Sawicz" <email address hidden>
ha scritto:

> Review: Needs Information
>
> What is the problem with the InverseMouseArea?
>
> Also, shouldn't this be a separate tst_DashContent test?
> --
>
> https://code.launchpad.net/~andyrock/unity/inverse-mouse-area-previews/+merge/157557
> You are the owner of lp:~andyrock/unity/inverse-mouse-area-previews.
>

I think your InverseMouseArea issue is with the fact that the DashContent is 0x0 size, so the sensing area is thus 0x0.

The DashPreview itself should not know / care about currentIndex - it's the Dash* components that should. The DashPreview could in theory be used outside of any ListView (not to mention outside of DashContent).

I don't think we need a DashContent here at all.

For future reference - you're accessing dashContent in DashPreview, which means accessing objects from out of DashPreview's scope directly. You should instead use properties / signals on the DashPreview to maintain encapsulation.

> I think your InverseMouseArea issue is with the fact that the DashContent is
> 0x0 size, so the sensing area is thus 0x0.

Nope, it does not work even removing sensingArea: dashContent.

>
> The DashPreview itself should not know / care about currentIndex - it's the
> Dash* components that should. The DashPreview could in theory be used outside
> of any ListView (not to mention outside of DashContent).
>
> I don't think we need a DashContent here at all.
>
> For future reference - you're accessing dashContent in DashPreview, which
> means accessing objects from out of DashPreview's scope directly. You should
> instead use properties / signals on the DashPreview to maintain encapsulation.

There seems to be a bug in the SDK, (see bug #1166127) - you can add an explicit sensingArea that spans the whole component for now.

> > The DashPreview itself should not know / care about currentIndex - it's the
> > Dash* components that should. The DashPreview could in theory be used
> outside
> > of any ListView (not to mention outside of DashContent).
> >
> > I don't think we need a DashContent here at all.
> >
> > For future reference - you're accessing dashContent in DashPreview, which
> > means accessing objects from out of DashPreview's scope directly. You should
> > instead use properties / signals on the DashPreview to maintain
> encapsulation.

For the moment I removed that change. This is actually another bug, will propose a new branch soon.

PASSED: Continuous integration, rev:548
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/333/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/unity-phablet-qmluitests/65
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/334
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/334/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/333
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/209
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/209/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/209
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/744

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/333/rebuild

PASSED: Continuous integration, rev:549
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/334/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/unity-phablet-qmluitests/66
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/335
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/335/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/334
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/210
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/210/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/210
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/745

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/334/rebuild

What's the MouseArea for? And the yellow Recatangle?

> What's the MouseArea for? And the yellow Recatangle?

I can remove the yellow Rectangle but without MouseArea how can I test that clicking outside the preview emits the close signal?

Hey, there's a conflict in tst_DashPreview.qml, can you please fix?

> I can remove the yellow Rectangle but without MouseArea how can I test
> that clicking outside the preview emits the close signal?

The InverseMouseArea will take care of that, you don't need the MouseArea, you just need to try and deliver a click to the preview's dismissArea.

mouseClick(preview.dismissArea, 1, 1)

Sweet. I'll fix it ASAP
Il giorno 15/apr/2013 15:25, "Michał Sawicz" <email address hidden>
ha scritto:

> Review: Needs Fixing
>
> > I can remove the yellow Rectangle but without MouseArea how can I test
> > that clicking outside the preview emits the close signal?
>
> The InverseMouseArea will take care of that, you don't need the MouseArea,
> you just need to try and deliver a click to the preview's dismissArea.
>
> mouseClick(preview.dismissArea, 1, 1)
> --
>
> https://code.launchpad.net/~andyrock/unity/inverse-mouse-area-previews/+merge/157557
> You are the owner of lp:~andyrock/unity/inverse-mouse-area-previews.
>

Its a good start, however, I don't think this should be merged as long as it just replaces the TODO's with FIXME's

49 + // FIXME: Workaround for bug: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1166127

Better wait until the InverseMouseArea is really fixed and fix this properly afterwards...

Ok.