Unity

Merge lp://staging/~azzar1/unity/fix-1044681 into lp://staging/unity

  1. fix-1044681
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 2712
Proposed branch: lp://staging/~azzar1/unity/fix-1044681
Merge into: lp://staging/unity
Diff against target: 607 lines (+210/-118)
12 files modified
dash/DashController.cpp (+2/-2)
dash/DashView.cpp (+8/-6)
panel/WindowButtons.cpp (+6/-7)
panel/WindowButtons.h (+2/-1)
tests/CMakeLists.txt (+1/-0)
tests/test_unity_settings.cpp (+110/-0)
unity-shared/DashStyle.cpp (+4/-4)
unity-shared/OverlayRenderer.cpp (+3/-3)
unity-shared/PanelStyle.cpp (+3/-3)
unity-shared/UnitySettings.cpp (+61/-80)
unity-shared/UnitySettings.h (+9/-11)
unity-standalone/StandaloneUnity.cpp (+1/-1)
To merge this branch: bzr merge lp://staging/~azzar1/unity/fix-1044681
Reviewer Review Type Date Requested Status
Omer Akram (community) functional Approve
Review via email: mp+124630@code.staging.launchpad.net

Commit message

Refactor unity::Settings to use nux::RWProperty.

Description of the change

== Problem ==
Bug #1044681: [regression] Minimizing a window does not give focus to the window behind

== Fix ==
Refactored unity::Settings to use RWProperty.

== Test ==
Unit tests added for unity::Settings.

To post a comment you must log in.
Revision history for this message
Omer Akram (om26er) wrote :

fix works for me.

review: Approve (functional)
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1334/console reported an error when processing this lp:~andyrock/unity/fix-1044681 branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.