Unity

Merge lp://staging/~azzar1/unity/fix-1024113 into lp://staging/unity

  1. fix-1024113
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 2525
Proposed branch: lp://staging/~azzar1/unity/fix-1024113
Merge into: lp://staging/unity
Diff against target: 75 lines (+13/-19)
3 files modified
launcher/Launcher.cpp (+0/-18)
launcher/Launcher.h (+0/-1)
manual-tests/Launcher.txt (+13/-0)
To merge this branch: bzr merge lp://staging/~azzar1/unity/fix-1024113
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Marco Trevisan (Treviño) Approve
jenkins (community) continuous-integration Approve
Review via email: mp+115726@code.staging.launchpad.net

This proposal supersedes a proposal from 2012-07-12.

Commit message

Remove "strut hack" in launcher.cpp

Description of the change

== Problem ==
Screen flickers when changing launcher icon size.

== Fix ==
Remove "strut hack". I can't see any regressions without it.

== Test ==
Manual test.

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:2500
http://jenkins.qa.ubuntu.com/job/unity-ci/99/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-ci/./distribution=quantal,flavor=amd64/99/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-ci/./distribution=quantal,flavor=i386/99/console

review: Approve (continuous-integration)
Revision history for this message
jenkins (martin-mrazik+qa) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2501
http://jenkins.qa.ubuntu.com/job/unity-ci/101/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-ci/./distribution=quantal,flavor=amd64/101/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-ci/./distribution=quantal,flavor=i386/101/console

review: Needs Fixing (continuous-integration)
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

PASSED: Continuous integration, rev:2501
http://jenkins.qa.ubuntu.com/job/unity-ci/102/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-ci/./distribution=quantal,flavor=amd64/102/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-ci/./distribution=quantal,flavor=i386/102/console

review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Fine!

review: Approve
Revision history for this message
Michal Hruby (mhr3) wrote :

The removal of the timer was causing that the strut wasn't applied in some cases after unity startup. A different fix for the flicker will need to be done.

review: Approve
Revision history for this message
Michal Hruby (mhr3) wrote :

Sorry, my comment was supposed to go to https://code.launchpad.net/~andyrock/unity/revert-2525/+merge/118055

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.