Unity

Merge lp://staging/~azzar1/unity/fix-1003950 into lp://staging/unity

  1. fix-1003950
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Merged
Approved by: Martin Mrazik
Approved revision: no longer in the source branch.
Merged at revision: 3021
Proposed branch: lp://staging/~azzar1/unity/fix-1003950
Merge into: lp://staging/unity
Diff against target: 678 lines (+443/-37)
8 files modified
tests/CMakeLists.txt (+3/-1)
tests/bamf-mock-window.c (+239/-0)
tests/bamf-mock-window.h (+80/-0)
tests/mock-application.h (+6/-0)
tests/test_bamf_application.cpp (+86/-0)
unity-shared/ApplicationManager.h (+3/-0)
unity-shared/BamfApplicationManager.cpp (+12/-20)
unity-shared/BamfApplicationManager.h (+14/-16)
To merge this branch: bzr merge lp://staging/~azzar1/unity/fix-1003950
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Marco Trevisan (Treviño) Approve
Review via email: mp+140781@code.staging.launchpad.net

Commit message

Include unmapped windows in unity::bamf::Application::GetWindows too.

Description of the change

== Problem ==
Launcher does not show minimized update manager while clicked.

== Fix ==
Include unmapped windows in unity::bamf::Application::GetWindows too.

== Test ==
Unit test added.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

76 +bamf_mock_window_set_transient (BamfMockWindow *self, BamfWindow* transient)
77 +{
78 + g_return_if_fail (BAMF_IS_MOCK_WINDOW (self));
79 + self->priv->transient = g_object_ref(transient);
80 +}

Mhmh... Probably it's better not to ref it here, since the parent window can be also closed... Probably it's better to add a weak ref instead.

Revision history for this message
Andrea Azzarone (azzar1) wrote :

> 76 +bamf_mock_window_set_transient (BamfMockWindow *self, BamfWindow*
> transient)
> 77 +{
> 78 + g_return_if_fail (BAMF_IS_MOCK_WINDOW (self));
> 79 + self->priv->transient = g_object_ref(transient);
> 80 +}
>
> Mhmh... Probably it's better not to ref it here, since the parent window can
> be also closed... Probably it's better to add a weak ref instead.

Done.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ops, I think you removed too much. You still need to do
  self->priv->transient = transient;

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Looks good, thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/277/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/./build=pbuilder,distribution=raring,flavor=amd64/277/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/./build=pbuilder,distribution=raring,flavor=i386/277/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/281/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/./build=pbuilder,distribution=raring,flavor=amd64/281/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/./build=pbuilder,distribution=raring,flavor=i386/281/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Andrea Azzarone (azzar1) wrote :

> FAILED: Autolanding.
> More details in the following jenkins job:
> http://jenkins.qa.ubuntu.com/job/unity-mbs-autolanding/281/
> Executed test runs:
> FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mbs-
> autolanding/./build=pbuilder,distribution=raring,flavor=amd64/281/console
> FAILURE: http://jenkins.qa.ubuntu.com/job/unity-mbs-
> autolanding/./build=pbuilder,distribution=raring,flavor=i386/281/console

Are we still building with old bamf?

Revision history for this message
Martin Mrazik (mrazik) wrote :

Just for the reference -- yes, it was building with old bamf package. Re-approve fixed it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.