Merge lp://staging/~azzar1/unity-lens-files/add-filesystem-icons into lp://staging/unity-lens-files

Hi Andrea, nice job, it works well and looks good, however it's missing support for recently introduced previews - if you right-click on a device icon in the dash, an empty preview is displayed and an error is printed to the stderr:

(process:3255): unity-files-daemon-WARNING **: daemon.vala:1042: Couldn't stat file: 'device://099A-74A7'

Could you please check with design what would they like to see as a device preview and implement the missing bits in the preview(..) method?

Manual tests should now follow the format requested by QA - see TEST_TEMPLATE.txt in unity source code. I know existing tests don't follow it (and need to be fixed), but when we introduce new tests file we should stick to the new format.

Also some minor comments:

This can fail and throw GLib.Error:
415 + AppInfo.launch_default_for_uri (get_volume_uri (), null);

Formatting issues (spaces missing):
363 + public Volume volume {get; set construct; }

378 + Object (volume:volume, uri:"device://"+uuid, icon:icon_name, display_name:name, dnd_uri:"device://"+uuid);

> Hi Andrea, nice job, it works well and looks good, however it's missing
> support for recently introduced previews - if you right-click on a device icon
> in the dash, an empty preview is displayed and an error is printed to the
> stderr:
>
> (process:3255): unity-files-daemon-WARNING **: daemon.vala:1042: Couldn't stat
> file: 'device://099A-74A7'
>
> Could you please check with design what would they like to see as a device
> preview and implement the missing bits in the preview(..) method?

Hey thank you for the review and sorry for the delay (I was quite busy).
I'll add preview support (already talked with John Lea about it).

>
> Manual tests should now follow the format requested by QA - see
> TEST_TEMPLATE.txt in unity source code. I know existing tests don't follow it
> (and need to be fixed), but when we introduce new tests file we should stick
> to the new format.
>

Will do.

> Also some minor comments:
>
> This can fail and throw GLib.Error:
> 415 + AppInfo.launch_default_for_uri (get_volume_uri (), null);
>
>
> Formatting issues (spaces missing):
> 363 + public Volume volume {get; set construct; }
>
> 378 + Object (volume:volume, uri:"device://"+uuid, icon:icon_name,
> display_name:name, dnd_uri:"device://"+uuid);

Will fix.

*poke*

The preview looks fine, but I found a general problem with how uri for device item is constructed: if you plug a device with more than 1 partition, you get same uris for all partitions. I've a usb stick with 2 partitions (each partition has a different name though), and get 2 "device://0012-D687" uris for them. Left clicking on such item in the dash will always activate the same partition; also preview navigation (left/right arrow in the preview) is misbehaving in such case.

Maybe we can use mount point to build the uri. It should be easy enough to change.

Ok I've updated the branch to use mount point as IDs. I need to update unity trunk too.

yes, that sounds like a good fix.

Yay, it works now! Thanks!

MMM we cannot use the mount point because if the volume is not mounted volume.get_activation_root() always return null (it shouldn't, but it does here). Btw I've a pen drive with two partitions and they have two different uris.

Uh, how about falling back to volume name or something else?
My pendrive may be a special case as it has two *factory* made partitions that you cannot remove (it's a MySQL-branded usb stick I got during last UDS).

Let's try with label :)